Skip to content

build: prefer local image resolution for docker driver - #1886

Merged
crazy-max merged 1 commit into
docker:masterfrom
crazy-max:docker-local
Jun 21, 2023
Merged

build: prefer local image resolution for docker driver#1886
crazy-max merged 1 commit into
docker:masterfrom
crazy-max:docker-local

Conversation

@crazy-max

Copy link
Copy Markdown
Member

If pull option is not set we should prefer local image resolution for docker driver. In follow-up we should look at making the --pull flag accepting a specific state like the docker run command does: https://docs.docker.com/engine/reference/commandline/run/#pull

@crazy-max
crazy-max marked this pull request as ready for review June 15, 2023 16:15

@tianontianon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment threadtests/build.go
Comment threadtests/build.go
Comment threadtests/build.go
@thaJeztah

Copy link
Copy Markdown
Member

In follow-up we should look at making the --pull flag accepting a specific state like the docker run command does: https://docs.docker.com/engine/reference/commandline/run/#pull

@crazy-max
crazy-maxforce-pushed the docker-local branch 2 times, most recently from 967e46c to 4a43f33CompareJune 19, 2023 09:59
Comment threadtests/build.go
Comment thread.github/workflows/build.yml Outdated
Comment threadDockerfile
Comment threadDockerfile Outdated
Comment threadtests/build.go
Comment threadtests/build.go Outdated
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@crazy-max@thaJeztah@tianon@tonistiigi@jedevc