Uh oh!
There was an error while loading. Please reload this page.
test: register docker worker with containerd snapshotter - #1897
Conversation
| cmd := buildxCmd( | ||
| sb, | ||
| withArgs("build", "-q", outFlag, "--iidfile", filepath.Join(targetDir, "iid.txt"), "--metadata-file", filepath.Join(targetDir, "md.json"), dir), | ||
| withArgs("build", "-q", "--provenance", "false", outFlag, "--iidfile", filepath.Join(targetDir, "iid.txt"), "--metadata-file", filepath.Join(targetDir, "md.json"), dir), |
There was a problem hiding this comment.
@tonistiigi Needs to disable provenance for this test with containerd storage as it would export an OCI image:
{
"containerimage.buildinfo": {
"frontend": "dockerfile.v0",
"attrs": {
"filename": "Dockerfile"
},
"sources": [
{
"type": "docker-image",
"ref": "docker.io/library/busybox:latest",
"pin": "sha256:0d5a701f0ca53f38723108687add000e1922f812d4187dea7feaee85d2f5a6c5"
}
]
},
"containerimage.descriptor": {
"mediaType": "application/vnd.oci.image.index.v1+json",
"digest": "sha256:ce51e4ac359feabf7a34388bb599e84873ba9299ce8b863ead9a093a16ffc875",
"size": 855
},
"containerimage.digest": "sha256:ce51e4ac359feabf7a34388bb599e84873ba9299ce8b863ead9a093a16ffc875",
"image.name": "moby-dangling@sha256:ce51e4ac359feabf7a34388bb599e84873ba9299ce8b863ead9a093a16ffc875"
}This is a test case we can add in follow-up. I guess we need to read "containerimage.descriptor".annotations."config.digest".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
59ff674 to
90c0bffCompareHum no tests run with |
90c0bff to
4778fbfCompare4778fbf to
1f308afCompareSigned-off-by: CrazyMax <crazy-max@users.noreply.github.com>
1f308af to
155eb3aComparecrazy-max
commented
Jun 20, 2023
So it's fine with |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
155eb3a to
28a1eb3Compare| ARG TARGETPLATFORM | ||
| ARG DOCKER_VERSION | ||
| WORKDIR /opt/docker | ||
| RUN DOCKER_ARCH=$(case ${TARGETPLATFORM:-linux/amd64} in \ |
There was a problem hiding this comment.
Can't you do this with xx-info march ?
follow-up #1886 (comment)
Adds
docker+containerdworker to our matrix to be able to test against dockerd with containerd storage enabled.