Skip to content

vendor: github.com/docker/docker, docker/cli v28.0.4 - #3033

Merged
crazy-max merged 3 commits into
docker:masterfrom
thaJeztah:remove_notary
Mar 28, 2025
Merged

vendor: github.com/docker/docker, docker/cli v28.0.4#3033
crazy-max merged 3 commits into
docker:masterfrom
thaJeztah:remove_notary

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Mar 1, 2025

Copy link
Copy Markdown
Member

vendor: github.com/docker/docker v28.0.4

full diff: moby/moby@v28.0.2...v28.0.3

vendor: vendor: github.com/docker/cli v28.0.4

This removes Notary / Docker Content Trust related (indirect)
dependencies;

Before:

makee binaries
# ...
ls -l bin/build/
total 131200
-rwxr-xr-x 1 thajeztah staff 67039266 Mar 21 09:20 buildx*
ls -lh bin/build/
total 131200
-rwxr-xr-x 1 thajeztah staff 64M Mar 21 09:20 buildx*

After:

makee binaries
# ...
ls -l bin/build/
total 127288
-rwxr-xr-x 1 thajeztah staff 65168450 Mar 21 09:22 buildx*
ls -lh bin/build/
total 127288
-rwxr-xr-x 1 thajeztah staff 62M Mar 21 09:22 buildx*

Difference: 67039266 - 65168450 = 1870816 (1.87 MB)

full diff: docker/cli@v28.0.2...v28.0.3

@thaJeztah
thaJeztahforce-pushed the remove_notary branch 4 times, most recently from 263c5cc to 1c71ad5CompareMarch 3, 2025 11:57
@thaJeztah
thaJeztahforce-pushed the remove_notary branch 3 times, most recently from 85dd6dd to 62b4162CompareMarch 8, 2025 17:43
@thaJeztah
thaJeztahforce-pushed the remove_notary branch 2 times, most recently from 232c546 to 925156bCompareMarch 10, 2025 16:55
@thaJeztah
thaJeztahforce-pushed the remove_notary branch 3 times, most recently from d13c52d to df26dbfCompareMarch 25, 2025 13:32
@thaJeztahthaJeztah changed the title vendor: github.com/docker/clivendor: github.com/docker/docker, docker/cli v28.0.3Mar 25, 2025
@thaJeztah
thaJeztah marked this pull request as ready for review March 25, 2025 13:33
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

Moved out of draft now that v28.0.3 was tagged

@crazy-max@vvoland PTAL 🤗

@thaJeztah
thaJeztah marked this pull request as draft March 25, 2025 14:53
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

Moved to draft; looks like there's a regression in v28.0.3, and not sure if it will impact buildx; docker/cli#5964

full diff: moby/moby@v28.0.2...v28.0.4
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This removes Notary / Docker Content Trust related (indirect)
dependencies;
Before:
ls -l bin/build/
total 131200
-rwxr-xr-x 1 thajeztah staff 67039266 Mar 21 09:20 buildx*
ls -lh bin/build/
total 131200
-rwxr-xr-x 1 thajeztah staff 64M Mar 21 09:20 buildx*
After:
ls -l bin/build/
total 127288
-rwxr-xr-x 1 thajeztah staff 65168450 Mar 21 09:22 buildx*
ls -lh bin/build/
total 127288
-rwxr-xr-x 1 thajeztah staff 62M Mar 21 09:22 buildx*
Difference: `67039266 - 65168450 = 1870816` (1.87 MB)
full diff: docker/cli@v28.0.2...v28.0.4
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah changed the title vendor: github.com/docker/docker, docker/cli v28.0.3vendor: github.com/docker/docker, docker/cli v28.0.4Mar 25, 2025
@thaJeztah
thaJeztah marked this pull request as ready for review March 25, 2025 18:02
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

Moved out of draft again; alas, some dependencies are back, but we may be able to get rid of them in the next release.

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

@vvoland@crazy-max I think this one should be good to go?

@crazy-max
crazy-max merged commit 8efc528 into docker:masterMar 28, 2025
@thaJeztah
thaJeztah deleted the remove_notary branch March 28, 2025 14:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@crazy-max@vvoland@thompson-shaun