Skip to content

Revert "cli/command: remove uses of GetAuthConfigKey, ParseRepositoryInfo" - #5964

Merged
thaJeztah merged 1 commit into
docker:masterfrom
vvoland:fix-auth-regression
Mar 25, 2025
Merged

Revert "cli/command: remove uses of GetAuthConfigKey, ParseRepositoryInfo"#5964
thaJeztah merged 1 commit into
docker:masterfrom
vvoland:fix-auth-regression

Conversation

@vvoland

@vvolandvvoland commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator

This reverts commit 79141ce.

Fix a regression causing `docker pull/push` to fail when interacting with a private repository.

Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com

…Info"
This reverts commit 79141ce.
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvolandvvoland added this to the 28.0.4 milestone Mar 25, 2025
@vvoland
vvoland requested a review from thaJeztahMarch 25, 2025 14:38
@vvolandvvoland self-assigned this Mar 25, 2025
@codecov-commenter

codecov-commenter commented Mar 25, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 59.09%. Comparing base (2b0631f) to head (f596202).
Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #5964 +/- ##
==========================================
+ Coverage 59.08% 59.09% +0.01% 
==========================================
Files 354 354 Lines 29739 29733 -6 ==========================================
Hits 17572 17572 + Misses 11197 11191 -6 
Partials 970 970 
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

trying to spot where the bug is, but there's so many levels of complexity in this code, so don't see it at a glance 😞

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to pull image from private repository after updating docker-ce-cli to 28.0.3

3 participants

@vvoland@codecov-commenter@thaJeztah