Uh oh!
There was an error while loading. Please reload this page.
build: add options to builder prune - #1327
Merged
tiborvass merged 2 commits intoSep 5, 2018
Merged
Conversation
tiborvassforce-pushed
the
cmd-builder-prune-with-options
branch
3 times, most recently
from
August 30, 2018 21:21
d2c48d1 to
8d4de02CompareCodecov Report
@@ Coverage Diff @@## master #1327 +/- ##
==========================================
- Coverage 54.82% 54.64% -0.19%
==========================================
Files 292 293 +1 Lines 19267 19360 +93 ==========================================
+ Hits 10564 10580 +16 - Misses 8044 8119 +75 - Partials 659 661 +2 |
tiborvassforce-pushed
the
cmd-builder-prune-with-options
branch
7 times, most recently
from
September 4, 2018 14:54
e89e1c3 to
82ee8e1Comparetiborvassforce-pushed
the
cmd-builder-prune-with-options
branch
from
September 4, 2018 15:33
82ee8e1 to
cd5550bCompare| sort.Slice(buildCache, func(i, j int) bool { | ||
| lui, luj := buildCache[i].LastUsedAt, buildCache[j].LastUsedAt | ||
| switch { | ||
| case lui == luj: |
Member
There was a problem hiding this comment.
explicit nil check is more readable
| case lui.Equal(*luj): | ||
| return strings.Compare(buildCache[i].ID, buildCache[j].ID) < 0 | ||
| } | ||
| return lui.Before(*luj) |
| buildCacheSort(ctx.BuildCache) | ||
| for _, v := range ctx.BuildCache { | ||
| t.Execute(ctx.Output, *v) | ||
| if !v.Shared { |
Member
There was a problem hiding this comment.
Shouldn't filter in here, but in the summary bytes.
This patch adds --filter, --keep-storage, --all and --force to builder prune. Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvassforce-pushed
the
cmd-builder-prune-with-options
branch
7 times, most recently
from
September 5, 2018 03:30
3c46602 to
b774911CompareSigned-off-by: Tibor Vass <tibor@docker.com>
tiborvassforce-pushed
the
cmd-builder-prune-with-options
branch
from
September 5, 2018 03:31
b774911 to
ca608c2Compare1 task
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tibor Vass tibor@docker.com
Related to moby/moby#37651
This patch fixes the UX around build cache:
--filter,--keep-storage,--all,--force. This is needed to to avoid situations where user needs to prune all their cache, and they can thus prune only a subset of their cache.system dfconsistent with the way other types are shown (containers, images, volumes...)