Skip to content

builder: add df command - #1333

Closed
tiborvass wants to merge 1 commit into
docker:masterfrom
tiborvass:cmd-builder-df
Closed

builder: add df command#1333
tiborvass wants to merge 1 commit into
docker:masterfrom
tiborvass:cmd-builder-df

Conversation

@tiborvass

Copy link
Copy Markdown
Collaborator

Depends on #1327

Adds docker builder df to show only build cache usage.

@vdemeestervdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@codecov-io

codecov-io commented Sep 4, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1333 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1333 +/- ##
=======================================
Coverage 54.64% 54.64% =======================================
Files 293 293 Lines 19360 19360 =======================================
Hits 10580 10580 Misses 8119 8119 Partials 661 661

@tiborvass
tiborvassforce-pushed the cmd-builder-df branch 6 times, most recently from 6bf2904 to 007db66CompareSeptember 5, 2018 03:33

@andrewhsuandrewhsu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Signed-off-by: Tibor Vass <tibor@docker.com>
@AkihiroSuda

Copy link
Copy Markdown
Collaborator

why was this closed?

@tiborvass

tiborvass commented Sep 6, 2018

Copy link
Copy Markdown
CollaboratorAuthor

@AkihiroSuda Because I'm working on another PR to open soon to show all detailed information in system df by removing the conflict between -v and --format, so you could do docker system df -v --format raw or docker system df -v --format '{{json .}}' There were a couple of issues with builder df: it was calling /system/df, no way of filtering with options. We'd rather do it right then rush it in.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tiborvass@codecov-io@AkihiroSuda@vdemeester@andrewhsu@GordonTheTurtle