Uh oh!
There was an error while loading. Please reload this page.
Refine how metadata dir is handled - #1405
Merged
Merged
Conversation
This is a follow up PR to docker#1381 to address some of the review comments we didn't get to. Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com> (cherry picked from commit c12e23a) Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
codecov-io
commented
Oct 1, 2018
Codecov Report
@@ Coverage Diff @@## master #1405 +/- ##
==========================================
- Coverage 54.29% 54.24% -0.06%
==========================================
Files 289 289 Lines 19326 19341 +15 ==========================================
- Hits 10494 10491 -3 - Misses 8154 8174 +20 + Partials 678 676 -2 |
thaJeztah
approved these changes
Oct 2, 2018
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM
ping @silvin-lubecki PTAL; this one is needed to have a clean cherry-pick of #1406 to master
dhiltgen
commented
Oct 2, 2018
ContributorAuthor
I'll PR the forward port on that one once this is merged. |
thaJeztah
commented
Oct 2, 2018
Member
@dhiltgen I had a branch already; I'll push in a couple of minutes |
thaJeztah
commented
Oct 2, 2018
Member
PR is up; #1409 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to #1381 to address some of the review comments
we didn't get to.
Signed-off-by: Daniel Hiltgen daniel.hiltgen@docker.com
(cherry picked from commit c12e23a)
Signed-off-by: Daniel Hiltgen daniel.hiltgen@docker.com
Forward port of #1388 to master.