Uh oh!
There was an error while loading. Please reload this page.
[18.09] Remove unused health check func - #1406
Merged
Merged
Conversation
During the refactoring for 18.09 the activate/update flows no longer restart the engine explicitly but let the user do that when they're ready, so the health check logic is no longer required. Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
codecov-io
commented
Oct 1, 2018
Codecov Report
@@ Coverage Diff @@## 18.09 #1406 +/- ##
==========================================
+ Coverage 54.09% 54.12% +0.02%
==========================================
Files 290 290 Lines 19313 19303 -10 ==========================================
- Hits 10448 10447 -1 + Misses 8201 8192 -9
Partials 664 664 |
thaJeztah
commented
Oct 2, 2018
Member
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #1388
During the refactoring for 18.09 the activate/update flows no longer
restart the engine explicitly but let the user do that when they're ready,
so the health check logic is no longer required.
Signed-off-by: Daniel Hiltgen daniel.hiltgen@docker.com