Uh oh!
There was an error while loading. Please reload this page.
Use official shellcheck image - #1538
Conversation
thaJeztah
commented
Nov 29, 2018
This PR is built on top of #1537, so marking it WIP; only the last commit is new. ping @vdemeester@albers PTAL |
thaJeztah
commented
Nov 29, 2018
For reference; these are the failures when using the Details |
0077c51 to
a6dbbf9CompareCodecov Report
@@ Coverage Diff @@## master #1538 +/- ##
=======================================
Coverage 56.12% 56.12% =======================================
Files 306 306 Lines 21030 21030 =======================================
Hits 11803 11803 Misses 8373 8373 Partials 854 854 |
a6dbbf9 to
4cf7785ComparethaJeztah
commented
Nov 29, 2018
hm.. forgot that circleci still expects Trying to find why it passed for me yesterday, but fails now 🤔 |
thaJeztah
commented
Nov 29, 2018
Ah; must've tried with |
thaJeztah
commented
Nov 29, 2018
Right, and I see all the failures are due to three new checks that were added in shellcheck v0.4.7;
I'll update the PR to use |
0bfe2bd to
9896b9dCompare9896b9d to
4f8115aCompare4026a9e to
2cdf492Compare2cdf492 to
40fa43cCompareThis patch switches the shellcheck image to use the official image from Docker Hub. Note that this does not yet update shellcheck to the latest version (v0.5.x); Shellcheck v0.4.7 added some new checks, which makes CI currently fail, so will be done in a follow-up PR. Instead, the v0.4.6 version is used in this PR, which is closest to the same version as was installed in the image before this change; ``` docker run --rm docker-cli-shell-validate shellcheck --version ShellCheck - shell script analysis tool version: 0.4.4 license: GNU General Public License, version 3 website: http://www.shellcheck.net ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
40fa43c to
388646eCompare
This patch switches the shellcheck image to use the official image from Docker Hub.
Note that this does not yet update shellcheck to the latest version (v0.5.x); Shellcheck v0.4.7 added some new checks, which makes CI currently fail, so will be done in a follow-up PR. Instead, the v0.4.6 version is used in this PR, which is closest to the same version as was installed in the image before this change;