Uh oh!
There was an error while loading. Please reload this page.
Upgrade shellcheck 0.6.0 - #1693
Merged
Merged
Conversation
thaJeztah
commented
Feb 26, 2019
MemberAuthor
thaJeztah
commented
Feb 26, 2019
| # - SC2119: Use foo "$@" if function's $1 should mean script's $1. | ||
| # - SC2155: Declare and assign separately to avoid masking return values. | ||
| # - SC2206: Quote to prevent word splitting, or split robustly with mapfile or read -a. | ||
| # - SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). |
MemberAuthor
There was a problem hiding this comment.
Disabled these for this file to ignore errors, such as;
In contrib/completion/bash/docker line 314:
COMPREPLY=( $(compgen -W "$(__docker_volumes "$@")" -- "$current") )
^-- SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
In contrib/completion/bash/docker line 347:
plugins=(${plugins[@]/$del/})
^-- SC2206: Quote to prevent word splitting, or split robustly with mapfile or read -a.
Collaborator
There was a problem hiding this comment.
I verified: Yes, these warnings really don't make sense here.
codecov-io
commented
Feb 26, 2019
Codecov Report
@@ Coverage Diff @@## master #1693 +/- ##
=======================================
Coverage 56.12% 56.12% =======================================
Files 306 306 Lines 21025 21025 =======================================
Hits 11800 11800 Misses 8371 8371 Partials 854 854 |
Codecov Report
@@ Coverage Diff @@## master #1693 +/- ##
==========================================
- Coverage 56.12% 56.12% -0.01%
==========================================
Files 306 306 Lines 21030 21025 -5 ==========================================
- Hits 11803 11800 -3 + Misses 8373 8371 -2
Partials 854 854 |
thaJeztah
commented
Feb 26, 2019
Uh oh!
There was an error while loading. Please reload this page.
This patch switches the shellcheck image to use the official image from Docker Hub. Note that this does not yet update shellcheck to the latest version (v0.5.x); Shellcheck v0.4.7 added some new checks, which makes CI currently fail, so will be done in a follow-up PR. Instead, the v0.4.6 version is used in this PR, which is closest to the same version as was installed in the image before this change; ``` docker run --rm docker-cli-shell-validate shellcheck --version ShellCheck - shell script analysis tool version: 0.4.4 license: GNU General Public License, version 3 website: http://www.shellcheck.net ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
upgrade_shellcheck_0.6.0
branch
from
February 26, 2019 14:11
238c48e to
a830734CompareSigned-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
upgrade_shellcheck_0.6.0
branch
from
February 26, 2019 14:13
a830734 to
ff107b3ComparethaJeztah
commented
Mar 2, 2019
MemberAuthor
ping @albers PTAL 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1538 (decided to keep it separate in case we needed to discuss the new exclusions)
As a bonus; changing to the official, alpine-based image makes this image substantially smaller;
current master:
with official shellcheck v0.4.6 image
with official shellcheck v0.6.0 image