Skip to content

bump docker-credential-helpers v0.6.2 - #1935

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:bump_credential_helpers
Jun 20, 2019
Merged

bump docker-credential-helpers v0.6.2#1935
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:bump_credential_helpers

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

full diff: docker/docker-credential-helpers@5241b46...8a9f93a

includes:

full diff: docker/docker-credential-helpers@5241b46...8a9f93a
includes:
- docker/docker-credential-helpers#29 C.free(unsafe.Pointer(err)) -> C.g_error_free(err)
- docker/docker-credential-helpers#124 pass: changed the way for checking if password-store is initalized
- addresses docker/docker-credential-helpers#133 docker-credential-pass commits about 10 times every time I run a docker command
- docker/docker-credential-helpers#143 Fix docker-credential-osxkeychain list behaviour in case of missing entry in keychain
- docker/docker-credential-helpers#139 make docker-credential-wincred work like docker-credential-osxkeychain
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

ping @ulrich@guillaumerose ptal

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1935 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1935 +/- ##
=======================================
Coverage 56.72% 56.72% =======================================
Files 310 310 Lines 21800 21800 =======================================
Hits 12367 12367 Misses 8518 8518 Partials 915 915

@LaurentDumont

LaurentDumont commented Jun 20, 2019

Copy link
Copy Markdown

Just got bit by this. Looking forward to the merge 👯‍♂️

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

ping @vdemeester@silvin-lubecki PTAL

@vdemeestervdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@thaJeztah@codecov-io@LaurentDumont@vdemeester@guillaumerose@GordonTheTurtle