Skip to content

[18.09 backport] bump docker-credential-helpers v0.6.3 - #1984

Merged
thaJeztah merged 2 commits into
docker:18.09from
thaJeztah:18.09_backport_bump_credential_helpers
Aug 8, 2019
Merged

[18.09 backport] bump docker-credential-helpers v0.6.3#1984
thaJeztah merged 2 commits into
docker:18.09from
thaJeztah:18.09_backport_bump_credential_helpers

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Jul 4, 2019

Copy link
Copy Markdown
Member

"WIP" because this is based on top of #1961

backport of #1935 and #2006

full diff: docker/docker-credential-helpers@5241b46...8a9f93a

includes:

bump v0.6.3:

full diff: docker/docker-credential-helpers@v0.6.2...v0.6.3

@codecov-io

codecov-io commented Jul 4, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1984 into 18.09 will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## 18.09 #1984 +/- ##
=======================================
Coverage 54.29% 54.29% =======================================
Files 291 291 Lines 19459 19459 =======================================
Hits 10565 10565 Misses 8214 8214 Partials 680 680

@thaJeztahthaJeztah changed the title [WIP][18.09 backport] bump docker-credential-helpers v0.6.2[WIP][18.09 backport] bump docker-credential-helpers v0.6.3Jul 18, 2019
@thaJeztahthaJeztah modified the milestones: 18.09.8, 18.09.9Jul 18, 2019
@thaJeztahthaJeztah changed the title [WIP][18.09 backport] bump docker-credential-helpers v0.6.3[18.09 backport] bump docker-credential-helpers v0.6.3Jul 23, 2019
@thaJeztah
thaJeztahforce-pushed the 18.09_backport_bump_credential_helpers branch from ada7ce0 to 76c6467CompareJuly 23, 2019 23:36
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

rebased

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

Interesting; e2e fails with: https://jenkins.dockerproject.org/job/docker/job/cli/job/PR-1984/4/console

23:53:17 Cannot connect to the Docker daemon at tcp://172.21.0.2:2375. Is the docker daemon running?
23:53:18 Cannot connect to the Docker daemon at tcp://172.21.0.2:2375. Is the docker daemon running?
23:53:18 Cannot connect to the Docker daemon at tcp://172.21.0.2:2375. Is the docker daemon running?
23:53:19 docker.Makefile:131: recipe for target 'test-e2e-non-experimental' failed
23:53:19 make: *** [test-e2e-non-experimental] Error 124

But the test should be running using the docker socket;

.PHONY: test-e2e-non-experimental
test-e2e-non-experimental: build_e2e_image
docker run --rm -v /var/run/docker.sock:/var/run/docker.sock $(E2E_IMAGE_NAME)

full diff: docker/docker-credential-helpers@5241b46...8a9f93a
includes:
- docker/docker-credential-helpers#29 C.free(unsafe.Pointer(err)) -> C.g_error_free(err)
- docker/docker-credential-helpers#124 pass: changed the way for checking if password-store is initalized
- addresses docker/docker-credential-helpers#133 docker-credential-pass commits about 10 times every time I run a docker command
- docker/docker-credential-helpers#143 Fix docker-credential-osxkeychain list behaviour in case of missing entry in keychain
- docker/docker-credential-helpers#139 make docker-credential-wincred work like docker-credential-osxkeychain
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit f6a4c76)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: docker/docker-credential-helpers@v0.6.2...v0.6.3
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 64f0ae4)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the 18.09_backport_bump_credential_helpers branch from 76c6467 to ea2b474CompareAugust 8, 2019 01:41

@kolyshkinkolyshkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (given that CI is green)

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

all green now

@thaJeztah
thaJeztah merged commit f3af74c into docker:18.09Aug 8, 2019
@thaJeztah
thaJeztah deleted the 18.09_backport_bump_credential_helpers branch August 8, 2019 02:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-io@kolyshkin@GordonTheTurtle