Uh oh!
There was an error while loading. Please reload this page.
config.Load() remove unneeded locks - #3025
Merged
Merged
Conversation
These were added in b83bc67, but I'm not sure why I added these; they're likely not needed. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Mar 25, 2021
MemberAuthor
Failing because of #2986 |
thaJeztah
marked this pull request as ready for review
March 25, 2021 21:53
thaJeztah
commented
Mar 25, 2021
MemberAuthor
tiborvass
approved these changes
Apr 1, 2021
coryb
commented
Aug 21, 2021
Contributor
@thaJeztah I think I figured out why you added this originally, I now get a race error when I run my tests with so the mutex was preventing the mutation of global state. Not sure if there is a better strategy to handle this or if we should add back in the mutex to prevent the race. |
coryb added a commit
to coryb/cli
that referenced
this pull request
Aug 21, 2021
Locking was removed docker#3025 which allows for parallel calls to config.Load to modify global state. The consequence in this case is very mild, but it does trigger a DATA RACE exception when tests run with `-race` option.
coryb added a commit
to coryb/cli
that referenced
this pull request
Aug 21, 2021
Locking was removed docker#3025 which allows for parallel calls to config.Load to modify global state. The consequence in this case is very mild, but it does trigger a DATA RACE exception when tests run with `-race` option. Signed-off-by: coryb <cbennett@netflix.com>
coryb added a commit
to coryb/cli
that referenced
this pull request
Aug 21, 2021
Locking was removed in docker#3025 which allows for parallel calls to config.Load to modify global state. The consequence in this case is innocuous, but it does trigger a `DATA RACE` exception when tests run with `-race` option. Signed-off-by: coryb <cbennett@netflix.com>
thaJeztah
commented
Aug 21, 2021
MemberAuthor
Ah! Nice find! |
thaJeztah pushed a commit
to thaJeztah/cli
that referenced
this pull request
Jan 27, 2022
Locking was removed in docker#3025 which allows for parallel calls to config.Load to modify global state. The consequence in this case is innocuous, but it does trigger a `DATA RACE` exception when tests run with `-race` option. Signed-off-by: coryb <cbennett@netflix.com> (cherry picked from commit b5f4a6e) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
gibson042 pushed a commit
to gibson042/docker-cli
that referenced
this pull request
Feb 1, 2022
Locking was removed in docker#3025 which allows for parallel calls to config.Load to modify global state. The consequence in this case is innocuous, but it does trigger a `DATA RACE` exception when tests run with `-race` option. Signed-off-by: coryb <cbennett@netflix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were added in b83bc67 (#2666), but I'm not sure why I added these; they're likely not needed.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)