Uh oh!
There was an error while loading. Please reload this page.
fix innocuous data-race when config.Load called in parallel - #3264
Merged
Conversation
Locking was removed in docker#3025 which allows for parallel calls to config.Load to modify global state. The consequence in this case is innocuous, but it does trigger a `DATA RACE` exception when tests run with `-race` option. Signed-off-by: coryb <cbennett@netflix.com>
codecov-commenter
commented
Aug 21, 2021
Codecov Report
@@ Coverage Diff @@## master #3264 +/- ##
=======================================
Coverage 57.98% 57.98% =======================================
Files 302 302 Lines 21754 21757 +3 =======================================
+ Hits 12613 12616 +3
Misses 8218 8218 Partials 923 923 |
thaJeztah
commented
Aug 21, 2021
Member
I recall we reverted it after a post-merge review, and we thought it wasn't needed. But the context load code is overly complicated with various conditions, so it doesn't surprise me it was needed after all 😁 |
crazy-max
approved these changes
Jan 27, 2022
crazy-max
left a comment
Member
There was a problem hiding this comment.
Also encountered this one in a test suite.
thaJeztah
commented
Jan 27, 2022
Member
Yes, let's get this one in (we can probably remove this stuff after the next release) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locking was removed in #3025 which allows for parallel calls to config.Load to modify global state. The consequence in this case is innocuous, but it does trigger a
DATA RACEexception when tests run with-raceoption.