Skip to content

GitHub Actions cross - #3234

Merged
silvin-lubecki merged 1 commit into
docker:masterfrom
crazy-max:gha-build
Oct 1, 2021
Merged

GitHub Actions cross#3234
silvin-lubecki merged 1 commit into
docker:masterfrom
crazy-max:gha-build

Conversation

@crazy-max

@crazy-maxcrazy-max commented Aug 6, 2021•
edited
Loading

Copy link
Copy Markdown
Member
  • Switch To GitHub Actions for cross target
    • also store artifacts temporarly (90d by default in repo settings) in the workflow (can remove that if you want)
    • and build dynbinary cross
    • use GitHub Action cache backend
  • Cleanup bake definition that was specific to CircleCI
  • Restore binary target in Makefile for non-sandboxed build
  • Fix README with proper lint command using bake

Run: https://github.com/docker/cli/actions/runs/1103549570

image

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@codecov-commenter

codecov-commenter commented Aug 6, 2021•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3234 (d9f4352) into master (56e5910) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3234 +/- ##
=======================================
Coverage 57.99% 57.99% =======================================
Files 302 302 Lines 21764 21764 =======================================
Hits 12621 12621 Misses 8219 8219 Partials 924 924

@crazy-max
crazy-max marked this pull request as ready for review August 6, 2021 06:43
thaJeztah
thaJeztah reviewed Aug 9, 2021
View reviewed changes
Comment threaddocker-bake.hcl
@crazy-max

crazy-max commented Aug 24, 2021

Copy link
Copy Markdown
MemberAuthor

PTAL @thaJeztah@silvin-lubecki :)

@crazy-max
crazy-maxforce-pushed the gha-build branch 2 times, most recently from e46442a to f8faa14CompareSeptember 3, 2021 13:05
@crazy-max

crazy-max commented Sep 15, 2021

Copy link
Copy Markdown
MemberAuthor

Removed GHA cache backend as we have issues with it.

@crazy-max

crazy-max commented Sep 23, 2021

Copy link
Copy Markdown
MemberAuthor

As discussed with @thaJeztah I restored the binary target to allow non-sandboxed build.

thaJeztah
thaJeztah approved these changes Sep 23, 2021
View reviewed changes

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

thaJeztah commented Sep 23, 2021

Copy link
Copy Markdown
Member

@silvin-lubecki PTAL

@crazy-maxcrazy-max mentioned this pull request Sep 23, 2021
Closed
@crazy-max
GitHub Actions cross
d9f4352
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-maxcrazy-max mentioned this pull request Sep 27, 2021
Merged
silvin-lubecki
silvin-lubecki approved these changes Oct 1, 2021
View reviewed changes

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki
silvin-lubecki merged commit e978593 into docker:masterOct 1, 2021
@crazy-max
crazy-max deleted the gha-build branch October 1, 2021 10:08
@crazy-maxcrazy-max mentioned this pull request Oct 1, 2021
Merged
@thaJeztahthaJeztah added this to the 21.xx milestone Oct 7, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztahthaJeztahthaJeztah approved these changes
@silvin-lubeckisilvin-lubeckisilvin-lubecki approved these changes

Assignees

No one assigned

Labels

area/testingstatus/2-code-review

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@crazy-max@codecov-commenter@thaJeztah@silvin-lubecki