Use goversioninfo to create Windows version info

[crazy-max]

Follow-up moby/moby#42872

- What I did

Replace windres with native Go implementation to be able to create a syso file which contains Microsoft Windows Version Information and an icon using goversioninfo.

This also fixes an issue with VERSIONINFO:

 > [linux/amd64 build 1/1] RUN --mount=ro --mount=type=cache,target=/root/.cache --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk --mount=type=tmpfs,target=cli/winresources xx-go --wrap && TARGET=/out ./scripts/build/binary && xx-verify $([ "static" = "static" ] && echo "--static") /out/docker:
#55 3.019 llvm-rc: Error in VERSIONINFO statement (ID 1): #55 3.038 FILEVERSION fields (1846769) does not fit in 16 bits.

Tool is not vendored but I can do that it if you want.

- How I did it

Remove windres references and replace with goversioninfo. Also use go:generate for better integration and add legal copyright field.

- How to verify it

docker buildx bake --set "*.platform=windows/amd64"
...
#16 [build 1/1] RUN --mount=type=bind,target=.,rw --mount=type=cache,target=/root/.cache --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk GO111MODULE=auto go install github.com/josephspurrier/goversioninfo/cmd/goversioninfo@v1.3.0 && xx-go --wrap && TARGET=/out ./scripts/build/binary && xx-verify $([ "static" = "static" ] && echo "--static") /out/docker#16 0.368 go: downloading github.com/josephspurrier/goversioninfo v1.3.0#16 0.826 go: downloading github.com/akavel/rsrc v0.10.2#16 1.425 Building static docker-windows-amd64.exe#16 1.437 {#16 1.437 "FixedFileInfo":#16 1.437 {#16 1.437 "FileVersion": {#16 1.437 "Major": 20,#16 1.437 "Minor": 10,#16 1.437 "Patch": 2,#16 1.437 "Build": 0#16 1.437 },#16 1.437 "FileFlagsMask": "3f",#16 1.437 "FileFlags ": "00",#16 1.437 "FileOS": "040004",#16 1.437 "FileType": "01",#16 1.437 "FileSubType": "00"#16 1.437 },#16 1.437 "StringFileInfo":#16 1.437 {#16 1.437 "Comments": "",#16 1.437 "CompanyName": "Docker, Inc.",#16 1.437 "FileDescription": "Docker Client",#16 1.437 "FileVersion": "20.10.2.0",#16 1.437 "InternalName": "",#16 1.437 "LegalCopyright": "Copyright (c) 2013-2021 Docker Inc. All rights reserved.",#16 1.437 "LegalTrademarks": "",#16 1.437 "OriginalFilename": "docker-windows-amd64.exe",#16 1.437 "PrivateBuild": "",#16 1.437 "ProductName": "Docker Client",#16 1.437 "ProductVersion": "20.10.2-263-gdd69cb4d7a.m",#16 1.437 "SpecialBuild": ""#16 1.437 },#16 1.437 "VarFileInfo":#16 1.437 {#16 1.437 "Translation": {#16 1.437 "LangID": "0409",#16 1.437 "CharsetID": "04B0"#16 1.437 }#16 1.437 }#16 1.437 }#16 1.437 + go generate -v github.com/docker/cli/cmd/docker#16 1.453 cmd/docker/docker.go#16 1.453 cmd/docker/docker_test.go#16 1.453 cmd/docker/docker_windows_amd64.go#16 1.478 + go build -o /out/docker-windows-amd64.exe -tags --ldflags ' -w -X "github.com/docker/cli/cli/version.GitCommit=dd69cb4d7a" -X "github.com/docker/cli/cli/version.BuildTime=2021-09-25T20:58:28Z" -X "github.com/docker/cli/cli/version.Version=20.10.2-263-gdd69cb4d7a.m" ' github.com/docker/cli/cmd/docker#16 DONE 5.0s

should produce:

COMPANY_NAME can be used to set the company that produced the windows binary.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

cc @thaJeztah

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

[codecov-commenter]

Codecov Report

Merging #3310 (79e933c) into master (f14d8e7) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3310 +/- ##
=======================================
Coverage 57.99% 57.99% =======================================
Files 302 302 Lines 21764 21764 =======================================
Hits 12621 12621 Misses 8219 8219 Partials 924 924 

[mat007]

Nice!

[crazy-max]

Also is the make.ps1 still used? I wonder if we could get rid of it in a follow-up? Same for appveyor.yml when #3234 is merged?

[thaJeztah]

This is just for debugging, correct? (wondering if it should do this by default, or left to the consumer of this script)

[crazy-max]

Yeah just for debugging and also audit in CI.

[crazy-max]

PTAL @thaJeztah@silvin-lubecki@mat007

[thaJeztah]

LGTM

[thaJeztah]

/cc @cpuguy83 (in case you're using this)

[thaJeztah]

LGTM!

[thaJeztah]

We discussed this change in the maintainers meeting, and everyone agreed that this was a nicer solution than what we had before, so I'll bring this in once CI finishes 👍