Uh oh!
There was an error while loading. Please reload this page.
create/run: remove default --stop-signal - #3245
Merged
Merged
Conversation
thaJeztahforce-pushed
the
remove_stopsignal_default
branch
2 times, most recently
from
August 12, 2021 15:50
c6705b0 to
8197e8eCompareCodecov Report
@@ Coverage Diff @@## master #3245 +/- ##
=======================================
Coverage 57.98% 57.98% =======================================
Files 302 302 Lines 21754 21753 -1 =======================================
+ Hits 12613 12614 +1 + Misses 8218 8217 -1 + Partials 923 922 -1 |
tianon
reviewed
Aug 18, 2021
| **--stop-signal**=*SIGTERM* | ||
| **--stop-signal**="" | ||
| Signal to stop a container. Default is SIGTERM. |
Contributor
There was a problem hiding this comment.
Should this maybe note the fact that the default can be defined by the image or something? (STOPSIGNAL in Dockerfile)
Suggested change
| Signal to stop a container. Default is SIGTERM. | |
| Signal to stop a container. Default is defined by `STOPSIGNAL` in the image or `SIGTERM` if not defined. |
MemberAuthor
There was a problem hiding this comment.
Ah, yes, makes sense to add, let me add some of that; thanks!
thaJeztahforce-pushed
the
remove_stopsignal_default
branch
from
August 21, 2021 13:03
8197e8e to
6671f40ComparethaJeztah
commented
Aug 21, 2021
MemberAuthor
I did some further rewriting of the docs, and moved a large part to #3261 (included in this PR; first two commits are from there) |
thaJeztah
commented
Aug 21, 2021
Uh oh!
There was an error while loading. Please reload this page.
thaJeztahforce-pushed
the
remove_stopsignal_default
branch
from
August 21, 2021 16:35
6671f40 to
6d420caCompareThe DefaultStopSignal const has been deprecated, because the daemon already handles a default value. The current code did not actually send the default value unless the flag was set, which also made the flag description incorrect, because in that case, the _daemon's_ default would be used, which could potentially be different as was specified here. This patch removes the default value from the flag, leaving it to the daemon to set a default. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
remove_stopsignal_default
branch
from
August 25, 2021 07:53
6d420ca to
214cd05ComparethaJeztah
commented
Aug 25, 2021
MemberAuthor
thaJeztah
commented
Sep 1, 2021
MemberAuthor
thaJeztah
commented
Sep 9, 2021
MemberAuthor
@silvin-lubecki PTAL 🤗 |
thaJeztah
commented
Nov 1, 2021
MemberAuthor
@silvin-lubecki@tonistiigi PTAL 🤗 |
jlecordier pushed a commit
to jlecordier/cli
that referenced
this pull request
Dec 8, 2021
create/run: remove default --stop-signal Signed-off-by: jlecordier <jeanlecordier@hotmail.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to moby/moby#42717
The DefaultStopSignal const has been deprecated, because the daemon already
handles a default value. The current code did not actually send the default
value unless the flag was set, which also made the flag description incorrect,
because in that case, the daemon's default would be used, which could
potentially be different as was specified here.
This patch removes the default value from the flag, leaving it to the daemon
to set a default.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)