Skip to content

docs: rewrite reference docs for --stop-signal and --stop-timeout, and use "console" hints - #3261

Merged
thaJeztah merged 2 commits into
docker:masterfrom
thaJeztah:docs_rewrite_and_codehints
Aug 25, 2021
Merged

docs: rewrite reference docs for --stop-signal and --stop-timeout, and use "console" hints#3261
thaJeztah merged 2 commits into
docker:masterfrom
thaJeztah:docs_rewrite_and_codehints

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

rewrite reference docs for --stop-signal and --stop-timeout, and use "console" code-hint for shell examples. This replaces the use of bash where suitable, to allow easier copy/pasting of shell examples without copying the prompt or process output.

(see docker/docs#13299)

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

@tianon@silvin-lubecki PTAL

@tianon perhaps you can review the first commit 🤗

@codecov-commenter

codecov-commenter commented Aug 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3261 (47ba76a) into master (c758c3e) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3261 +/- ##
=======================================
Coverage 57.98% 57.98% =======================================
Files 302 302 Lines 21754 21754 =======================================
Hits 12613 12613 Misses 8218 8218 Partials 923 923 

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This replaces the use of bash where suitable, to allow easier copy/pasting
of shell examples without copying the prompt or process output.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the docs_rewrite_and_codehints branch from f034272 to 47ba76aCompareAugust 21, 2021 16:29

@tianontianon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@thaJeztah
thaJeztah merged commit 1fdafcd into docker:masterAug 25, 2021
@thaJeztah
thaJeztah deleted the docs_rewrite_and_codehints branch August 25, 2021 07:49
@thaJeztahthaJeztah added this to the 21.xx milestone Oct 7, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah@codecov-commenter@tianon