Uh oh!
There was an error while loading. Please reload this page.
Use private network address for default-address-pools setting in daem… - #3295
Merged
thaJeztah merged 1 commit intoSep 16, 2021
Conversation
This was referenced Sep 11, 2021
Codecov Report
@@ Coverage Diff @@## master #3295 +/- ##
=======================================
Coverage 57.99% 57.99% =======================================
Files 302 302 Lines 21764 21764 =======================================
Hits 12621 12621 Misses 8219 8219 Partials 924 924 |
petross8901
approved these changes
Sep 12, 2021
…on.json example Signed-off-by: Pawel <pepawel@users.noreply.github.com>
pepawel
commented
Sep 16, 2021
ContributorAuthor
I've signed off the commit. Please approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
172.80.0.0/16 is a publicly routable internet address. It shouldn't be used as a private network.
Example in docker documentation encourages users to follow this bad practice.
This pull request changes network address used in example daemon.json file to correct private network.