Skip to content

Add bash completion for docker stack config - #3577

Merged
thaJeztah merged 2 commits into
docker:masterfrom
albers:completion-stack-config
Apr 30, 2022
Merged

Add bash completion for docker stack config#3577
thaJeztah merged 2 commits into
docker:masterfrom
albers:completion-stack-config

Conversation

@albers

Copy link
Copy Markdown
Collaborator

This adds bash completion for #3544.
Also removes the unsupported alias docker stack cfg from help output.

@codecov-commenter

codecov-commenter commented Apr 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3577 (381fb1d) into master (1497633) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3577 +/- ##
=======================================
Coverage 59.36% 59.36% =======================================
Files 287 287 Lines 24175 24175 =======================================
Hits 14352 14352 Misses 8958 8958 Partials 865 865 

This adds bash completion for docker#3544.
Signed-off-by: Harald Albers <github@albersweb.de>
@albers
albersforce-pushed the completion-stack-config branch from cb15d42 to e4381eeCompareApril 29, 2022 19:32
Signed-off-by: Harald Albers <github@albersweb.de>
@albers
albersforce-pushed the completion-stack-config branch from e4381ee to 381fb1dCompareApril 29, 2022 20:19
@albers

Copy link
Copy Markdown
CollaboratorAuthor

I got no idea how the failures in test / host (macos-latest) should be related to this PR.
Can someone please help?

@thaJeztah

Copy link
Copy Markdown
Member

Thanks! I completely forgot the completion this time (I recall looking at it when rebasing, but forgot to follow up 😞)

I got no idea how the failures in test / host (macos-latest) should be related to this PR.
Can someone please help?

Let me restart that one; it's known to be flaky; see #3554 (and #3573 for a workaround that's being worked on)

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thaJeztah

Copy link
Copy Markdown
Member

all green now 👍

@thaJeztah
thaJeztah merged commit 49c56da into docker:masterApr 30, 2022
@albers
albers deleted the completion-stack-config branch April 30, 2022 18:26
@dockerdocker deleted a comment from LeopereOct 4, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@albers@codecov-commenter@thaJeztah