Uh oh!
There was an error while loading. Please reload this page.
Remove bash completion for deprecated orchestrator flags - #3578
Merged
Conversation
See 039018b for corresponding docs change. Signed-off-by: Harald Albers <github@albersweb.de>
Codecov Report
@@ Coverage Diff @@## master #3578 +/- ##
=======================================
Coverage 59.36% 59.36% =======================================
Files 287 287 Lines 24175 24175 =======================================
Hits 14352 14352 Misses 8958 8958 Partials 865 865 |
thaJeztah
commented
Apr 30, 2022
Member
❤️ Thanks!! I marked this PR as "replaces/closes" #3439, which I never got round to addressing your comments (😓); gave it a try, and looks to be working as expected 👍 |
albers
commented
Apr 30, 2022
CollaboratorAuthor
Thanks @thaJeztah. But my PR only covers bash completion, so maybe you could carry the zsh part of #3439? |
thaJeztah
commented
May 1, 2022
Member
Ah, good one; yes, let me reopen that one, and only include the zsh commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See 039018b for corresponding docs change.