Skip to content

Support for rollback config in compose 3.7 - #409

Merged
thaJeztah merged 2 commits into
docker:masterfrom
alshabib:order
May 29, 2018
Merged

Support for rollback config in compose 3.7#409
thaJeztah merged 2 commits into
docker:masterfrom
alshabib:order

Conversation

@alshabib

@alshabibalshabib commented Aug 1, 2017

Copy link
Copy Markdown

Fixesmoby/moby#32585

- What I did

Built off #360 to provide support for rollback config in compose 3.4. ie.

 deploy:
replicas: 1
rollback_config:
parallelism: 1

- How I did it

Added the key to the schema, regenerated the schema and tied it to existing UpdateConfig type.

- How to verify it

docker stack deploy -c docker-compose.yml yay

with the following stack:

version: '3.7'
services:
busy:
image: busybox
deploy:
replicas: 1
rollback_config:
parallelism: 1
ports:
- 80:80

- Description for the changelog
This pull request adds support for rollback configurations to be specified in the YAML stack file. Given that it is build off the aforementioned pull request, it supports also rollback_config.order.

- A picture of a cute animal (not mandatory but encouraged)

dog

@codecov-io

codecov-io commented Aug 1, 2017

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@824a0b4). Click here to learn what that means.
The diff coverage is 0%.

@@ Coverage Diff @@## master #409 +/- ##
=========================================
Coverage ? 50.52% =========================================
Files ? 216 Lines ? 17724 Branches ? 0 =========================================
Hits ? 8955 Misses ? 8321 Partials ? 448

@dnephindnephin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alshabib

Copy link
Copy Markdown
Author

anything blocking this?

@vdemeestervdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

@vdemeester

Copy link
Copy Markdown
Collaborator

@vieux@dnephin has 17.08 freeze started or shouldn't this be for compose 3.5 ?

@sirlatrom

Copy link
Copy Markdown
Contributor

@alshabib Any chance you could update this PR so it might make it into spec version 3.5?

@alshabib

Copy link
Copy Markdown
Author

Sure. Just pushed an update.

@dnephin

Copy link
Copy Markdown
Contributor

This needs to be moved to version 3.5 schema now, otherwise LGTM

@Vadus

Vadus commented Dec 29, 2017

Copy link
Copy Markdown

is this in 3.5 already ?

and does the rollback_config also work on <service> -> deploy: -> update_config: -> failure_action: rollback ?

@vdemeester

Copy link
Copy Markdown
Collaborator

@thaJeztah rebased, fixed conflicts and update to be on composefile 3.7 👼

@thaJeztahthaJeztah changed the title Support for rollback config in compose 3.4Support for rollback config in compose 3.7May 29, 2018
@vdemeester
vdemeesterforce-pushed the order branch 3 times, most recently from cfe0a96 to 6d966fcCompareMay 29, 2018 09:23

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw one thing, LGTM otherwise

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Signed-off-by: Vincent Demeester <vincent@sbr.pm>

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we need a procedure to "stage" upcoming compose file changes (ie the 3.7 schema should be considered -dev until it's released)

@thaJeztah
thaJeztah merged commit 5bc09eb into docker:masterMay 29, 2018
@GordonTheTurtleGordonTheTurtle added this to the 18.06.0 milestone May 29, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@alshabib@codecov-io@vdemeester@sirlatrom@dnephin@Vadus@thaJeztah@GordonTheTurtle