Uh oh!
There was an error while loading. Please reload this page.
Add 3.7 schema and add rollback_config to it - #5992
Conversation
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
15c2341 to
4b45a31Compare| API_VERSIONS[COMPOSEFILE_V3_4]: '17.06.0', | ||
| API_VERSIONS[COMPOSEFILE_V3_5]: '17.06.0', | ||
| API_VERSIONS[COMPOSEFILE_V3_6]: '18.02.0', | ||
| API_VERSIONS[COMPOSEFILE_V3_7]: '18.02.0', |
There was a problem hiding this comment.
well, I wasn't sure about that. From my understanding, it's the "lowest" API version supported. And so far, there is nothing in v3.7 that wasn't already supported by v3.6 ; this is why I did put the same version.
There was a problem hiding this comment.
It's true that we used to do that, however, in retrospect it confuses people and makes things harder to document. For people who insist on using newer Compose file versions with an older engine (I don't think there are many), they can always set COMPOSE_API_VERSION to override.
As a result I'd recommend using 18.06.0 here.
Ignoring it on docker-compose Signed-off-by: Vincent Demeester <vincent@sbr.pm>
4b45a31 to
70574efComparevdemeester
commented
May 30, 2018
Updated 👼 |
shin-
commented
May 30, 2018
Thank you! 🥇 |
thaJeztah
commented
May 30, 2018
Note that ideally, we'd have some other compose-file changes in as well;
@shin- not sure if you work with release-branches, so let me know if you were planning to do a release (because after it's in a release, we likely can't change the compose-file spec anymore) @vdemeester for the above; issues; I'll try to find some time, but if you have some and can help 🤗 |
shin-
commented
May 30, 2018
@thaJeztah I don't think we'll do a release before at least mid-June, so things should be alright on that end. |
thaJeztah
commented
May 30, 2018
Thanks! Feel free to ping me if things change in that respect 👍 |
vdemeester
commented
May 30, 2018
@thaJeztah can take care of it 😉 |
thaJeztah
commented
May 30, 2018
@vdemeesterdocker/cli#479 could be tricky; when I had the CLI working, I think SwarmKit still didn't pick up the configuration (but perhaps I did something wrong); I can push that branch as a quick WIP |
Mirrors docker/cli#409. As for
update_config, it will be ignore bydocker-compose😉cc @thaJeztah@shin-