cli/command: some cleanups / refactoring, and fixes related to auth

[thaJeztah]

cli/command: ConfigureAuth: fix terminal state not being restored on error

ConfigureAuth used the readInput() utility to read the username and password.
However, this utility did not return errors it encountered, but instead did
an os.Exit(1). A result of this was that the terminal was not restored if
an error happened. When reading the password, the terminal is configured to
disable echo (i.e. characters are not printed), and failing to restore
the previous state means that the terminal is now "non-functional".

This patch:

• changes readInput() to return errors it encounters
• uses a defer() to restore terminal state

cli/command: ConfigureAuth: trim whitespace both for username and password

changes readInput() to trim whitespace. The existing code tried to be
conservative and only trimmed whitespace for username (not for password).
Passwords with leading/trailing whitespace would be very unlikely, and
trimming whitespace is generally accepted.

cli/command/registry: remove intermediate var that collided

This also simplifies the code a bit.

cli/command: replace EncodeAuthToBase64 for registry.EncodeAuthConfig

Replace uses of this function in favor of the implementation in the
API types, so that we have a single, canonical implementation.

cli/command/container/create: pullImage(): use RetrieveAuthTokenFromImage

replace the local code with RetrieveAuthTokenFromImage, which does exactly the same;

cli/cli/command/registry.go

Lines 163 to 188 in 6233560

	// RetrieveAuthTokenFromImage retrieves an encoded auth token given a complete image
	funcRetrieveAuthTokenFromImage(ctx context.Context, cliCli, imagestring) (string, error) {
	// Retrieve encoded auth token from the image reference
	authConfig, err:=resolveAuthConfigFromImage(ctx, cli, image)
	iferr!=nil {
	return"", err
	}
	encodedAuth, err:=EncodeAuthToBase64(authConfig)
	iferr!=nil {
	return"", err
	}
	returnencodedAuth, nil
	}
	// resolveAuthConfigFromImage retrieves that AuthConfig using the image string
	funcresolveAuthConfigFromImage(ctx context.Context, cliCli, imagestring) (registrytypes.AuthConfig, error) {
	registryRef, err:=reference.ParseNormalizedNamed(image)
	iferr!=nil {
	return registrytypes.AuthConfig{}, err
	}
	repoInfo, err:=registry.ParseRepositoryInfo(registryRef)
	iferr!=nil {
	return registrytypes.AuthConfig{}, err
	}
	returnResolveAuthConfig(ctx, cli, repoInfo.Index), nil
	}

cli/command/container/create: pullImage() remove intermediate vars

cli/command/container: pullImage: use DisplayJSONMessagesToStream utility

This utility provides the same logic as was implemented here (and using it
aligns with the "docker pull" equivalent).

Also added a TODO to replace this function with the regular "docker pull"
code.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[thaJeztah]

@rumpl@laurazard ptal 🤗

[codecov-commenter]

Codecov Report

Merging #4190 (17df83e) into master (b799ab9) will decrease coverage by 0.01%.
The diff coverage is 39.39%.

❗ Current head 17df83e differs from pull request most recent head 5d856a5. Consider uploading reports for the commit 5d856a5 to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## master #4190 +/- ##
==========================================
- Coverage 58.86% 58.85% -0.01% 
==========================================
Files 572 572 Lines 49576 49492 -84 ==========================================
- Hits 29182 29130 -52 + Misses 18624 18598 -26 + Partials 1770 1764 -6 

[thaJeztah]

oh! I think I forgot to push some of the changes. let me dig them up

[thaJeztah]

all green now 👍