Skip to content

[24.0 backport] login: Add message about using PATs - #4500

Merged
thaJeztah merged 1 commit into
docker:24.0from
neersighted:backport_4478
Aug 17, 2023
Merged

[24.0 backport] login: Add message about using PATs#4500
thaJeztah merged 1 commit into
docker:24.0from
neersighted:backport_4478

Conversation

@neersighted

@neersightedneersighted commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

- What I did

Added a hint about using PATs

$ docker loginLog in with your Docker ID or email address to push and pull images from Docker Hub. If you don't have a Docker ID, head over to https://hub.docker.com/ to create one.You can log in with your password or a Personal Access Token (PAT). Using a limited-scope PAT grants better security and is required for organizations using SSO. Learn more at https://docs.docker.com/go/access-tokens/Username: 

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
(cherry picked from commit 8d51f36)
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #4500 (1160626) into 24.0 (27a1996) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files
@@ Coverage Diff @@## 24.0 #4500 +/- ##
==========================================
- Coverage 59.27% 59.26% -0.02% 
==========================================
Files 288 286 -2 Lines 24810 24810 ==========================================
- Hits 14707 14703 -4 - Misses 9215 9218 +3 - Partials 888 889 +1 

@thaJeztah

Copy link
Copy Markdown
Member

Slight conflict due to a lack of #4190

Should we consider backporting that one as a whole, or not worth it? (I need to recall the exact cases where it fixes things)

@neersighted

Copy link
Copy Markdown
ContributorAuthor

I don't think it's worth it -- it was de-duplication of code/removal of deprecated functions, with the exception of:

cli/command: ConfigureAuth: fix terminal state not being restored on error

which doesn't cleanly apply (due to other cleanup) -- up to you, but I'm not sure it's worth it myself.

@thaJeztah

Copy link
Copy Markdown
Member

Looks like the wrong "missing" PR was linked; this is the one not in v24;

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
thaJeztah merged commit 580730f into docker:24.0Aug 17, 2023
@neersighted
neersighted deleted the backport_4478 branch August 17, 2023 19:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@neersighted@codecov-commenter@thaJeztah@laurazard@rumpl