Skip to content

image/tree: Chips to represent "in use" - #5744

Merged
vvoland merged 1 commit into
docker:masterfrom
vvoland:image-tree-chips
Feb 4, 2025
Merged

image/tree: Chips to represent "in use"#5744
vvoland merged 1 commit into
docker:masterfrom
vvoland:image-tree-chips

Conversation

@vvoland

@vvolandvvoland commented Jan 14, 2025

Copy link
Copy Markdown
Collaborator

Replace In Use column with Extra (needs a better name though), that uses "chips" / "badges" to show whether the image is in use.

image
`docker images --tree` now shows metadata badges

@vvolandvvoland added area/ux containerd-integration Issues and PRs related to containerd integration labels Jan 14, 2025
@vvolandvvoland self-assigned this Jan 14, 2025
@vvoland
vvolandforce-pushed the image-tree-chips branch 2 times, most recently from 0e3e9d2 to dc2b0ceCompareJanuary 14, 2025 12:29
@codecov-commenter

codecov-commenter commented Jan 14, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 2.84360% with 205 lines in your changes missing coverage. Please review.

Project coverage is 59.26%. Comparing base (17c5fe6) to head (c950d48).
Report is 90 commits behind head on master.

❌ Your patch status has failed because the patch coverage (2.84%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@ Coverage Diff @@## master #5744 +/- ##
==========================================
- Coverage 59.42% 59.26% -0.17% 
==========================================
Files 347 353 +6 Lines 29402 29618 +216 ==========================================
+ Hits 17472 17552 +80 - Misses 10958 11086 +128 - Partials 972 980 +8 

@vvoland
vvoland marked this pull request as ready for review January 21, 2025 16:42
@vvoland
vvolandforce-pushed the image-tree-chips branch 4 times, most recently from c7934c1 to 860acf0CompareJanuary 22, 2025 15:24
@laurazard

Copy link
Copy Markdown
Member

I really like this! I wonder if INFO would be better for that header, or maybe no header at all?

@vvolandvvoland added this to the 28.0.0 milestone Jan 23, 2025
@vvoland

Copy link
Copy Markdown
CollaboratorAuthor

Changed to Info, WDYT?

@tianon

Copy link
Copy Markdown
Contributor

I'll echo what I said in the maintainer meeting yesterday: I don't mind the presentation, I like the idea of compressing the visible data where we can, but I do wonder whether we have enough users that care (or even should care) about whether or not an image has an attestation to display it by default. I'm all for the data being available on the CLI for custom --format strings so that tiny subset of users who do care about this data can add it, but adding it by default seems like a mistake (especially when it's such a lossy bit of data all by itself -- what kind of attestation? is this an SBOM? is this a provenance doc? is it a signature?).

"In Use", however, is something that I think is relevant to every user 👍

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvolandvvoland changed the title image/tree: Chips to represent "in use"/"attested"image/tree: Chips to represent "in use"Feb 3, 2025
@vvoland

Copy link
Copy Markdown
CollaboratorAuthor

Removed attested

@vvoland
vvoland merged commit 5b90e0e into docker:masterFeb 4, 2025
@koitsu

koitsu commented Apr 17, 2026

Copy link
Copy Markdown

How does one go about disabling this unnecessary feature? More specifically, disabling the waste-a-line-of-terminal-output-and-expand-to-full-width-of-terminal line that appears at the top of output?

I have dug through c950d48 and I do not see a way to inhibit this behaviour (other than not using a pseudo TTY).

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/uxcontainerd-integrationIssues and PRs related to containerd integrationkind/enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@vvoland@codecov-commenter@laurazard@tianon@koitsu@Benehiko