Skip to content

image/tree: Hide Content size column without containerd store - #5771

Closed
vvoland wants to merge 1 commit into
docker:masterfrom
vvoland:image-tree-contentsize
Closed

image/tree: Hide Content size column without containerd store#5771
vvoland wants to merge 1 commit into
docker:masterfrom
vvoland:image-tree-contentsize

Conversation

@vvoland

Copy link
Copy Markdown
Collaborator

With graph drivers, all content sizes are zero because the compressed content isn't stored.
This makes the whole column useless and wasting the terminal space.

Hide the whole column if all its values would be zero.

Before

image

After

image

@codecov-commenter

codecov-commenter commented Jan 24, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
cli/command/image/tree.go0.00%16 Missing ⚠️

📢 Thoughts on this report? Let us know!

@vvoland
vvoland requested a review from a teamJanuary 24, 2025 15:56
With graph drivers, all content sizes are zero because the compressed
content isn't stored.
This makes the whole column useless and wasting the terminal space.
Hide the whole column if all its values would be zero.
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland
vvolandforce-pushed the image-tree-contentsize branch from 8949711 to 203ce87CompareFebruary 4, 2025 09:24
@vvoland
vvoland marked this pull request as ready for review February 4, 2025 09:24
@Benehiko

Copy link
Copy Markdown
Member

@vvoland did you want this merged soon?

@thaJeztahthaJeztah modified the milestones: 28.0.0, 28.0.5Mar 31, 2025
@vvoland
vvoland marked this pull request as draft April 18, 2025 09:44
@vvolandvvoland modified the milestones: 28.1.1, 29.0.0Apr 18, 2025
@thaJeztahthaJeztah modified the milestones: 29.0.0, 29.2.0Jan 13, 2026
@thaJeztahthaJeztah modified the milestones: 29.2.0, 29.3.0Jan 26, 2026
@thaJeztahthaJeztah modified the milestones: 29.3.0, 29.3.1Mar 4, 2026
@thaJeztahthaJeztah modified the milestones: 29.4.0, 29.4.1Apr 3, 2026
@thaJeztahthaJeztah modified the milestones: 29.4.1, 29.4.2Apr 20, 2026
@vvoland

Copy link
Copy Markdown
CollaboratorAuthor

@thaJeztah I recall you had reservations about this - should we close it?

@vvolandvvoland removed this from the 29.4.2 milestone Apr 22, 2026
@vvolandvvoland closed this Apr 22, 2026
@vvolandvvoland added this to the 29.4.3 milestone May 1, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@vvoland@codecov-commenter@Benehiko@laurazard@thaJeztah