Skip to content

cli/command/completion: deprecate NoComplete - #6404

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:deprecate_nocomplete
Sep 1, 2025
Merged

cli/command/completion: deprecate NoComplete#6404
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:deprecate_nocomplete

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

This function was an exact duplicate of cobra.NoFileCompletions, so deprecating it in favor of that.

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

Go SDK: cli/command/completion: deprecate `NoComplete`

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztahthaJeztah added this to the 29.0.0 milestone Aug 30, 2025
@thaJeztah
thaJeztah requested review from a team and silvin-lubecki as code ownersAugust 30, 2025 09:58
@thaJeztahthaJeztah added impact/deprecation status/2-code-review area/completion kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK process/cherry-pick/28.x labels Aug 30, 2025
This function was an exact duplicate of [cobra.NoFileCompletions], so
deprecating it in favor of that.
[cobra.NoFileCompletions]: https://pkg.go.dev/github.com/spf13/cobra@v1.9.1#NoFileCompletions
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the deprecate_nocomplete branch from 103e86d to 2827d03CompareAugust 30, 2025 10:01
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
cli/command/service/inspect.go0.00%1 Missing ⚠️
cli/command/service/logs.go0.00%1 Missing ⚠️
cli/command/service/ps.go0.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thaJeztah
thaJeztah merged commit ba21666 into docker:masterSep 1, 2025
110 of 112 checks passed
@thaJeztah
thaJeztah deleted the deprecate_nocomplete branch September 1, 2025 07:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/completionarea/go-sdkChanges affecting the Go SDKimpact/deprecationimpact/go-sdkNoteworthy (compatibility changes) in the Go SDKkind/refactorPR's that refactor, or clean-up codeprocess/cherry-pickedstatus/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah@codecov-commenter@Benehiko