Skip to content

cli/command/completion: remove deprecated NoComplete - #6408

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:rm_NoComplete
Sep 1, 2025
Merged

cli/command/completion: remove deprecated NoComplete#6408
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:rm_NoComplete

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

This function was an exact duplicate of cobra.NoFileCompletions, and was deprecated in 2827d03.

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

Go SDK: cli/command/completion: remove deprecated `NoComplete`

- A picture of a cute animal (not mandatory but encouraged)

This function was an exact duplicate of [cobra.NoFileCompletions], and
was deprecated in 2827d03.
[cobra.NoFileCompletions]: https://pkg.go.dev/github.com/spf13/cobra@v1.9.1#NoFileCompletions
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah added this to the 29.0.0 milestone Sep 1, 2025
@thaJeztahthaJeztah added impact/deprecation status/2-code-review area/completion kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Sep 1, 2025
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@thaJeztah

Copy link
Copy Markdown
MemberAuthor
--- FAIL: TestNetworkPrunePromptTermination (0.01s)
prune_test.go:27: assertion failed: error is "network prune has been cancelled" (network.cancelledErr), not "prompt terminated" (prompt.ErrTerminated prompt.cancelledErr)
FAIL

@thaJeztah
thaJeztah merged commit 9a6cbbc into docker:masterSep 1, 2025
125 of 127 checks passed
@thaJeztah
thaJeztah deleted the rm_NoComplete branch September 1, 2025 10:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/completionarea/go-sdkChanges affecting the Go SDKimpact/deprecationimpact/go-sdkNoteworthy (compatibility changes) in the Go SDKkind/refactorPR's that refactor, or clean-up codestatus/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah@codecov-commenter@Benehiko