Uh oh!
There was an error while loading. Please reload this page.
feat: add blkio device options to docker container update - #7031
feat: add blkio device options to docker container update#7031acouvreur wants to merge 2 commits into
Conversation
11ba624 to
1c145a3CompareCodecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
0649cdb to
e03b777Comparee03b777 to
a37006fCompareSigned-off-by: Alexis Couvreur <alexiscouvreur.pro@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
a37006f to
17ae429Comparevvoland
commented
Jun 12, 2026
Thinking if we could align with the compose format a little bit more: https://docs.docker.com/reference/compose-file/services/#blkio_config |
| options := &updateOptions{ | ||
| blkioWeightDevice: opts.NewWeightdeviceOpt(opts.ValidateWeightDevice), | ||
| deviceReadBps: opts.NewThrottledeviceOpt(opts.ValidateThrottleBpsDevice), | ||
| deviceReadIOps: opts.NewThrottledeviceOpt(opts.ValidateThrottleIOpsDevice), | ||
| deviceWriteBps: opts.NewThrottledeviceOpt(opts.ValidateThrottleBpsDevice), | ||
| deviceWriteIOps: opts.NewThrottledeviceOpt(opts.ValidateThrottleIOpsDevice), | ||
| } |
There was a problem hiding this comment.
Had to do this otherwise it would not validate and send [nil] as slice, but it looks like it currently defaults to sending an empty slice, which would probably reset the existing values by default (so something to fix)
thaJeztah
commented
Jun 12, 2026
Yeah, we probably should look; currently it's aligning with |
thaJeztah
commented
Jun 12, 2026
Discussing with @vvoland on slack; given that there's still some bits to discuss (and a potential bug to be fixed); let's have a closer look at options and not rush. If we have a good plan soon, it can still be in v29.6.0-rc.2, otherwise we could shift it to v29.7 (which should not be far in the future) |
Closes#3325
Related to moby/moby#52651
- What I did
Add 5 options to
docker container updateto control the device blkio throttle.- How I did it
I simply added the same options from the create command to the update command to be able to pass the blkio device arguments for the update.
- How to verify it
The current version of the moby/moby library does not forward those arguments even though they exist in the struct.
You need to set the moby/moby version to the one in moby/moby#52651 and then create a docker container with a certain blkio device throttle configuration and then update it using docker container update. Then you can inspect the container for those new values.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)