Skip to content

vendor: github.com/moby/moby/api v1.55.0-rc.1, moby/client v0.5.0-rc.1 - #7051

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:bump_moby
Jun 12, 2026
Merged

vendor: github.com/moby/moby/api v1.55.0-rc.1, moby/client v0.5.0-rc.1#7051
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:bump_moby

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@docker-agent

Copy link
Copy Markdown
Contributor

⏱️ PR Review Timed Out — The review agent hit the 1800 s time limit before completing. This usually happens on large or complex diffs. You can re-trigger with /review — if it times out again, consider splitting the PR into smaller pieces.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah changed the title vendor: github.com/moby/moby/api v1.55.0-dev, moby/client v0.5.0-devvendor: github.com/moby/moby/api v1.55.0-rc.1, moby/client v0.5.0-rc.1Jun 12, 2026
@thaJeztah
thaJeztah marked this pull request as ready for review June 12, 2026 16:55
@thaJeztah
thaJeztah requested a review from vvolandJune 12, 2026 16:55

@docker-agentdocker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR vendors updated versions of github.com/moby/moby/api (v1.55.0-rc.1) and github.com/moby/moby/client (v0.5.0-rc.1), introducing the new ImageAttestations API.

No issues found. The new code is well-structured and follows existing conventions:

  • image_attestations.go: Correctly uses the established defer ensureReaderClosed(resp) pattern (matching image_inspect.go, image_history.go, etc.), proper API version guard via requiresVersion, context propagation, and error handling throughout.
  • image_attestations_opts.go: Clean functional-options pattern consistent with other option types in this package.
  • client_interfaces.go: Interface addition matches the concrete implementation's signature exactly.
  • attestation.go: New type file (not in diff but vendored correctly).
  • vendor.mod / vendor.sum / vendor/modules.txt: Dependency bookkeeping updated consistently.

@thaJeztah
thaJeztah merged commit 8c2e800 into docker:masterJun 12, 2026
102 checks passed
@thaJeztah
thaJeztah deleted the bump_moby branch June 12, 2026 17:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-commenter@docker-agent@vvoland