Skip to content

Add bash completion for --platform - #704

Merged
thaJeztah merged 1 commit into
docker:masterfrom
albers:completion--platform
Dec 4, 2017
Merged

Add bash completion for --platform#704
thaJeztah merged 1 commit into
docker:masterfrom
albers:completion--platform

Conversation

@albers

Copy link
Copy Markdown
Collaborator

This adds bash completion for #474.
The completion is only added when commands are run against a daemon running in experimental mode.

@albersalbers added this to the 17.12.0 milestone Nov 20, 2017
@codecov-io

codecov-io commented Nov 20, 2017

Copy link
Copy Markdown

Codecov Report

Merging #704 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #704 +/- ##
==========================================
- Coverage 51.81% 51.81% -0.01% 
==========================================
Files 218 218 Lines 17924 17924 ==========================================
- Hits 9288 9287 -1 - Misses 8160 8161 +1 
Partials 476 476

@thaJeztahthaJeztah changed the title Add bash completion for --publishAdd bash completion for --platformNov 29, 2017

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM, but can you update the commit description (you accidentally typed --publish instead of --platform 😄 )

Signed-off-by: Harald Albers <github@albersweb.de>
@albers
albersforce-pushed the completion--platform branch from 3878bf3 to 15f7841CompareNovember 30, 2017 08:30
@albers

Copy link
Copy Markdown
CollaboratorAuthor

can you update the commit description (you accidentally typed --publish instead of --platform 😄 )

Thanks for catching 😅!
Fixed and rebased (there was a conflict with --stream from #678).

@albers

Copy link
Copy Markdown
CollaboratorAuthor

@thaJeztah By the way, I got CI errors on #713 and #717 that survived several forced pushes, probably caused by

Could not update commit status. Message: Server returned HTTP response code: 201, message: 'Created' for URL: https://api.github.com/repos/docker/cli/statuses/9f5fb24854a578bcd9b778ff688efb9381efb68e

Do you know how I could get rid of these?

@vdemeestervdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

@albers

Copy link
Copy Markdown
CollaboratorAuthor

@thaJeztah The CI errors I asked you to look into are now gone after I rebased.

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! thanks for the ping

LGTM

@thaJeztah
thaJeztah merged commit 83cdc0f into docker:masterDec 4, 2017
@albers
albers deleted the completion--platform branch December 5, 2017 17:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@albers@codecov-io@vdemeester@thaJeztah@GordonTheTurtle