Skip to content

Fix #512 Bash autocompletion works incorrect with inspect - #713

Merged
dnephin merged 1 commit into
docker:masterfrom
albers:completion-512
Dec 15, 2017
Merged

Fix #512 Bash autocompletion works incorrect with inspect#713
dnephin merged 1 commit into
docker:masterfrom
albers:completion-512

Conversation

@albers

Copy link
Copy Markdown
Collaborator

Fixes#512

completion or docker inspect fails for all image names that contain a :, e.g. hello-world: or localhost:5000/hello-world/. The substring before the first : is duplicated, resulting in invalid image names.

Note: completion for docker inspect --type image or docker image inspect was not affected by this issue.

@codecov-io

codecov-io commented Nov 24, 2017

Copy link
Copy Markdown

Codecov Report

Merging #713 into master will increase coverage by 1.48%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #713 +/- ##
==========================================
+ Coverage 51.81% 53.29% +1.48% 
==========================================
Files 218 218 Lines 17924 14565 -3359 ==========================================
- Hits 9288 7763 -1525 + Misses 8160 6326 -1834 
Partials 476 476

@albers
albersforce-pushed the completion-512 branch 5 times, most recently from 4df0134 to 9f5fb24CompareNovember 29, 2017 14:50
Signed-off-by: Harald Albers <github@albersweb.de>

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnephin
dnephin merged commit 718a245 into docker:masterDec 15, 2017
@GordonTheTurtleGordonTheTurtle added this to the 18.01.0 milestone Dec 15, 2017
@albers
albers deleted the completion-512 branch December 16, 2017 08:00
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Fixdocker#512 Bash autocompletion works incorrect with inspect
Upstream-commit: 718a245
Component: cli
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@albers@codecov-io@dnephin@thaJeztah@GordonTheTurtle