Uh oh!
There was an error while loading. Please reload this page.
pkg/api: replace uuid for basic random id - #10953
Merged
Merged
Conversation
The uuid package in distribution was created as a utility for the distribution project itself, to cut down external dependencies (see [1][1]). For compose, this has the reverse effect, as it now brings all the dependencies of the distribution module with it. This patch switches to the uuid generation to crypto/rand to produce a random id. I was considering using a different uuid implementation, or docker's "stringid.GenerateRandomID", but all of those are doing more than needed, so keep it simple. Currently, this change has little effect, because compose also uses the distribution module for other purposes, but the distribution project is in the process of moving the "reference" package to a separate module, in which case we don't want to depend on the distribution module only for the uuid package. [1]: distribution/distribution@36e34a5 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@## main #10953 +/- ##
==========================================
- Coverage 58.32% 58.27% -0.05%
==========================================
Files 123 123 Lines 10864 10866 +2 ==========================================
- Hits 6336 6332 -4 - Misses 3909 3914 +5 - Partials 619 620 +1
☔ View full report in Codecov by Sentry. |
ndeloof
approved these changes
Aug 31, 2023
ndeloof
requested review from
a team, StefanScherer, glours, laurazard, milas, nicksieger and ulyssessouza
and removed request for
a teamAugust 31, 2023 14:04
milas
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The uuid package in distribution was created as a utility for the distribution project itself, to cut down external dependencies (see 1).
For compose, this has the reverse effect, as it now brings all the dependencies of the distribution module with it.
This patch switches to the uuid generation to crypto/rand to produce a random id. I was considering using a different uuid implementation, or docker's "stringid.GenerateRandomID", but all of those are doing more than needed, so keep it simple.
Currently, this change has little effect, because compose also uses the distribution module for other purposes, but the distribution project is in the process of moving the "reference" package to a separate module, in which case we don't want to depend on the distribution module only for the uuid package.
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did