Skip to content

migrate to github.com/distribution/reference - #10954

Merged
glours merged 1 commit into
docker:mainfrom
thaJeztah:swap_reference
Sep 4, 2023
Merged

migrate to github.com/distribution/reference#10954
glours merged 1 commit into
docker:mainfrom
thaJeztah:swap_reference

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

What I did

The "reference" package was moved to a separate module, which was extracted
from distribution/distribution@b9b1940

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@thaJeztah

thaJeztah commented Aug 31, 2023

Copy link
Copy Markdown
MemberAuthor

Looks like the distribution-types made their way into compose's signatures, so we need to wait for distribution to have that PR merged, and I'll also open a PR in compose-go

#21 142.4 cmd/main.go:33:2: could not import github.com/docker/compose/v2/pkg/compose (-: # github.com/docker/compose/v2/pkg/compose
#21 142.4 pkg/compose/compose.go:154:32: cannot use func(named reference.Named) (digest.Digest, error) {…} (value of type func(named "github.com/distribution/reference".Named) (digest.Digest, error)) as func(named "github.com/distribution/distribution/v3/reference".Named) (digest.Digest, error) value in argument to project.ResolveImages) (typecheck)
#21 142.4 "github.com/docker/compose/v2/pkg/compose"
#21 142.4 ^

@milasmilas added the dependencies Pull requests that update a dependency file label Aug 31, 2023
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

@ndeloof I kept it in draft because there was no tagged version of compose-go with this patch; do you want to have a tagged version first?

(:warning: not sure if that should be 1.18.x or if we want to be on the safe side, and to 1.19.0 so that we could still do 1.18.x patch releases without this switch)

@codecov

codecovBot commented Sep 4, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.06%⚠️

Comparison is base (32c3d0a) 58.32% compared to head (4a9d78b) 58.26%.

❗ Current head 4a9d78b differs from pull request most recent head f4f2e93. Consider uploading reports for the commit f4f2e93 to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@## main #10954 +/- ##
==========================================
- Coverage 58.32% 58.26% -0.06% 
==========================================
Files 124 124 Lines 10912 10912 ==========================================
- Hits 6364 6358 -6 - Misses 3918 3923 +5 - Partials 630 631 +1 
Files ChangedCoverage Δ
pkg/compose/compose.go61.32% <ø> (ø)
pkg/compose/image_pruner.go79.83% <ø> (ø)
pkg/compose/images.go72.60% <ø> (ø)
pkg/compose/pull.go75.62% <ø> (ø)
pkg/compose/push.go13.04% <ø> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The "reference" package was moved to a separate module, which was extracted
from distribution/distribution@b9b1940
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztah marked this pull request as ready for review September 4, 2023 12:37
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

compose-go v1.18.4 was tagged; moved this out of draft

@glours
glours merged commit 203bce8 into docker:mainSep 4, 2023
@thaJeztah
thaJeztah deleted the swap_reference branch September 4, 2023 16:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@ndeloof@glours@milas