Skip to content

Additional validation for container volumes and ports. - #442

Merged
aanand merged 3 commits into
docker:masterfrom
dnephin:fix_create_container_volumes
Sep 4, 2014
Merged

Additional validation for container volumes and ports.#442
aanand merged 3 commits into
docker:masterfrom
dnephin:fix_create_container_volumes

Conversation

@dnephin

@dnephindnephin commented Aug 24, 2014

Copy link
Copy Markdown

dnephin
dnephin reviewed Aug 24, 2014
View reviewed changes
Comment threaddocs/yml.md

@dnephindnephinAug 24, 2014

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen multiple people confused about this so I tried to clarify that this is only an issue on OSX, not linux.

@nathanleclairenathanleclaireAug 27, 2014

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dnephindnephin mentioned this pull request Aug 26, 2014
Closed
aanand
aanand reviewed Aug 26, 2014
View reviewed changes
Comment threadfig/service.py Outdated

@aanandaanandAug 26, 2014

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list-fiddling stuff is really confusing. Could we bring back the local variables, so I can see what's being returned in each case?

@dnephindnephinAug 26, 2014

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm happy to make some changes here. I think in order to validate the string properly, we still need to make it a list, but additional local variables I can add.

@aanand

aanand commented Aug 26, 2014

Copy link
Copy Markdown

Sorry I missed this. Looks good.

Could it be split out into several logical commits? A lot of things are conflated here.

@dnephin

dnephin commented Aug 26, 2014

Copy link
Copy Markdown
Author

Sure, I'm definitely happy to split this into a few commits.

@dnephin
dnephinforce-pushed the fix_create_container_volumes branch from 26a6e18 to a813717CompareAugust 26, 2014 02:18
@dnephin
Fix the return value of get_tty_width() it should return an int.
8157f08
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed the fix_create_container_volumes branch from a813717 to 9abdf34CompareAugust 26, 2014 02:20
@dnephin

dnephin commented Aug 26, 2014

Copy link
Copy Markdown
Author

Rebased into three commits, and added additional local variables for split_port()

@d11wtq

d11wtq commented Aug 27, 2014

Copy link
Copy Markdown

Awesome. Good to see this. Thanks for all your contributions, @dnephin! Massively appreciated.

@dnephindnephin mentioned this pull request Aug 27, 2014
Closed
@dnephin
dnephinforce-pushed the fix_create_container_volumes branch from 9abdf34 to be67aa7CompareAugust 28, 2014 03:32
@dnephindnephin mentioned this pull request Aug 28, 2014
Closed
7 tasks
@dnephin
Resolvesdocker#260,docker#301anddocker#449
07fa169
Adds ~ support and ro mode support for volumes, along with some additional validation.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
Some additional validation for container ports, and a couple extra te…
24044fa
…st cases.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed the fix_create_container_volumes branch from be67aa7 to 24044faCompareAugust 31, 2014 06:03
@dnephin

dnephin commented Aug 31, 2014

Copy link
Copy Markdown
Author

additional validation for mode (should be in ro, rw).

@bfirsh

bfirsh commented Sep 4, 2014

Copy link
Copy Markdown

LGTM

1 similar comment
@aanand

aanand commented Sep 4, 2014

Copy link
Copy Markdown

LGTM

aanand added a commit that referenced this pull request Sep 4, 2014
@aanand
Merge pull request#442from dnephin/fix_create_container_volumes
7ad91f3
Additional validation for container volumes and ports.
@aanand
aanand merged commit 7ad91f3 into docker:masterSep 4, 2014
@dnephin
dnephin deleted the fix_create_container_volumes branch September 5, 2014 01:59
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
@aanand
Merge pull requestdocker#442from dnephin/fix_create_container_volumes
0232a7c
Additional validation for container volumes and ports.
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Is it possible to assign a volume name using an environment variable? ~ in volume path Error when specifying permission in volume

5 participants

@dnephin@aanand@d11wtq@bfirsh@nathanleclaire
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Additional validation for container volumes and ports. by dnephin · Pull Request #442 · docker/compose · GitHub
Skip to content
Additional validation for container volumes and ports. - #442
Merged
aanand merged 3 commits into
docker:masterfrom 
dnephin:fix_create_container_volumes
Sep 4, 2014
Merged
Additional validation for container volumes and ports.#442
aanand merged 3 commits into
docker:masterfrom 
dnephin:fix_create_container_volumes
Conversation
@dnephin
@dnephindnephin
commented
Aug 24, 2014

Copy link


Copy Markdown

dnephin
dnephin
reviewed
Aug 24, 2014
 View reviewed changes

Comment threaddocs/yml.md
@dnephindnephinAug 24, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen multiple people confused about this so I tried to clarify that this is only an issue on OSX, not linux.
@nathanleclairenathanleclaireAug 27, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@dnephindnephin
mentioned this pull request
Aug 26, 2014
 Closed

aanand
aanand
reviewed
Aug 26, 2014
 View reviewed changes

Comment threadfig/service.py
Outdated

@aanandaanandAug 26, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list-fiddling stuff is really confusing. Could we bring back the local variables, so I can see what's being returned in each case?
@dnephindnephinAug 26, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm happy to make some changes here. I think in order to validate the string properly, we still need to make it a list, but additional local variables I can add.
@aanand
aanand
commented
Aug 26, 2014

Copy link


Copy Markdown

Sorry I missed this. Looks good.
Could it be split out into several logical commits? A lot of things are conflated here.
@dnephin
dnephin
commented
Aug 26, 2014

Copy link


Copy Markdown

Author
Sure, I'm definitely happy to split this into a few commits.
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
26a6e18 to
a813717CompareAugust 26, 2014 02:18
@dnephin
Fix the return value of get_tty_width() it should return an int.
8157f08
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
a813717 to
9abdf34CompareAugust 26, 2014 02:20
@dnephin
dnephin
commented
Aug 26, 2014

Copy link


Copy Markdown

Author
Rebased into three commits, and added additional local variables for split_port()
@d11wtq
d11wtq
commented
Aug 27, 2014

Copy link


Copy Markdown

Awesome. Good to see this. Thanks for all your contributions, @dnephin! Massively appreciated.
@dnephindnephin
mentioned this pull request
Aug 27, 2014

Closed

@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
9abdf34 to
be67aa7CompareAugust 28, 2014 03:32
@dnephindnephin
mentioned this pull request
Aug 28, 2014

Closed

7 tasks
@dnephin
Resolvesdocker#260,docker#301anddocker#449
07fa169
Adds ~ support and ro mode support for volumes, along with some additional validation.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
Some additional validation for container ports, and a couple extra te…
24044fa
…st cases.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
be67aa7 to
24044faCompareAugust 31, 2014 06:03
@dnephin
dnephin
commented
Aug 31, 2014

Copy link


Copy Markdown

Author
additional validation for mode (should be in ro, rw).
@bfirsh
bfirsh
commented
Sep 4, 2014

Copy link


Copy Markdown

LGTM

1 similar comment

@aanand
aanand
commented
Sep 4, 2014

Copy link


Copy Markdown

LGTM
aanand added a commit
that referenced
this pull request
Sep 4, 2014
@aanand
Merge pull request#442from dnephin/fix_create_container_volumes
7ad91f3
Additional validation for container volumes and ports.
@aanand
aanand
merged commit 7ad91f3
into
docker:masterSep 4, 2014
@dnephin
dnephin
deleted the

fix_create_container_volumes

branch
September 5, 2014 01:59
yuval-k pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
@aanand
Merge pull requestdocker#442from dnephin/fix_create_container_volumes
0232a7c
Additional validation for container volumes and ports.
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Is it possible to assign a volume name using an environment variable?

~ in volume path

Error when specifying permission in volume


5 participants

@dnephin@aanand@d11wtq@bfirsh@nathanleclaire

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Additional validation for container volumes and ports. by dnephin · Pull Request #442 · docker/compose · GitHub
Skip to content
Additional validation for container volumes and ports. - #442
Merged
aanand merged 3 commits into
docker:masterfrom 
dnephin:fix_create_container_volumes
Sep 4, 2014
Merged
Additional validation for container volumes and ports.#442
aanand merged 3 commits into
docker:masterfrom 
dnephin:fix_create_container_volumes
Conversation
@dnephin
@dnephindnephin
commented
Aug 24, 2014

Copy link


Copy Markdown

dnephin
dnephin
reviewed
Aug 24, 2014
 View reviewed changes

Comment threaddocs/yml.md
@dnephindnephinAug 24, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen multiple people confused about this so I tried to clarify that this is only an issue on OSX, not linux.
@nathanleclairenathanleclaireAug 27, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@dnephindnephin
mentioned this pull request
Aug 26, 2014
 Closed

aanand
aanand
reviewed
Aug 26, 2014
 View reviewed changes

Comment threadfig/service.py
Outdated

@aanandaanandAug 26, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list-fiddling stuff is really confusing. Could we bring back the local variables, so I can see what's being returned in each case?
@dnephindnephinAug 26, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm happy to make some changes here. I think in order to validate the string properly, we still need to make it a list, but additional local variables I can add.
@aanand
aanand
commented
Aug 26, 2014

Copy link


Copy Markdown

Sorry I missed this. Looks good.
Could it be split out into several logical commits? A lot of things are conflated here.
@dnephin
dnephin
commented
Aug 26, 2014

Copy link


Copy Markdown

Author
Sure, I'm definitely happy to split this into a few commits.
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
26a6e18 to
a813717CompareAugust 26, 2014 02:18
@dnephin
Fix the return value of get_tty_width() it should return an int.
8157f08
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
a813717 to
9abdf34CompareAugust 26, 2014 02:20
@dnephin
dnephin
commented
Aug 26, 2014

Copy link


Copy Markdown

Author
Rebased into three commits, and added additional local variables for split_port()
@d11wtq
d11wtq
commented
Aug 27, 2014

Copy link


Copy Markdown

Awesome. Good to see this. Thanks for all your contributions, @dnephin! Massively appreciated.
@dnephindnephin
mentioned this pull request
Aug 27, 2014

Closed

@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
9abdf34 to
be67aa7CompareAugust 28, 2014 03:32
@dnephindnephin
mentioned this pull request
Aug 28, 2014

Closed

7 tasks
@dnephin
Resolvesdocker#260,docker#301anddocker#449
07fa169
Adds ~ support and ro mode support for volumes, along with some additional validation.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
Some additional validation for container ports, and a couple extra te…
24044fa
…st cases.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
be67aa7 to
24044faCompareAugust 31, 2014 06:03
@dnephin
dnephin
commented
Aug 31, 2014

Copy link


Copy Markdown

Author
additional validation for mode (should be in ro, rw).
@bfirsh
bfirsh
commented
Sep 4, 2014

Copy link


Copy Markdown

LGTM

1 similar comment

@aanand
aanand
commented
Sep 4, 2014

Copy link


Copy Markdown

LGTM
aanand added a commit
that referenced
this pull request
Sep 4, 2014
@aanand
Merge pull request#442from dnephin/fix_create_container_volumes
7ad91f3
Additional validation for container volumes and ports.
@aanand
aanand
merged commit 7ad91f3
into
docker:masterSep 4, 2014
@dnephin
dnephin
deleted the

fix_create_container_volumes

branch
September 5, 2014 01:59
yuval-k pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
@aanand
Merge pull requestdocker#442from dnephin/fix_create_container_volumes
0232a7c
Additional validation for container volumes and ports.
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Is it possible to assign a volume name using an environment variable?

~ in volume path

Error when specifying permission in volume


5 participants

@dnephin@aanand@d11wtq@bfirsh@nathanleclaire

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Additional validation for container volumes and ports. by dnephin · Pull Request #442 · docker/compose · GitHub
Skip to content
Additional validation for container volumes and ports. - #442
Merged
aanand merged 3 commits into
docker:masterfrom 
dnephin:fix_create_container_volumes
Sep 4, 2014
Merged
Additional validation for container volumes and ports.#442
aanand merged 3 commits into
docker:masterfrom 
dnephin:fix_create_container_volumes
Conversation
@dnephin
@dnephindnephin
commented
Aug 24, 2014

Copy link


Copy Markdown

dnephin
dnephin
reviewed
Aug 24, 2014
 View reviewed changes

Comment threaddocs/yml.md
@dnephindnephinAug 24, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen multiple people confused about this so I tried to clarify that this is only an issue on OSX, not linux.
@nathanleclairenathanleclaireAug 27, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@dnephindnephin
mentioned this pull request
Aug 26, 2014
 Closed

aanand
aanand
reviewed
Aug 26, 2014
 View reviewed changes

Comment threadfig/service.py
Outdated

@aanandaanandAug 26, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list-fiddling stuff is really confusing. Could we bring back the local variables, so I can see what's being returned in each case?
@dnephindnephinAug 26, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm happy to make some changes here. I think in order to validate the string properly, we still need to make it a list, but additional local variables I can add.
@aanand
aanand
commented
Aug 26, 2014

Copy link


Copy Markdown

Sorry I missed this. Looks good.
Could it be split out into several logical commits? A lot of things are conflated here.
@dnephin
dnephin
commented
Aug 26, 2014

Copy link


Copy Markdown

Author
Sure, I'm definitely happy to split this into a few commits.
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
26a6e18 to
a813717CompareAugust 26, 2014 02:18
@dnephin
Fix the return value of get_tty_width() it should return an int.
8157f08
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
a813717 to
9abdf34CompareAugust 26, 2014 02:20
@dnephin
dnephin
commented
Aug 26, 2014

Copy link


Copy Markdown

Author
Rebased into three commits, and added additional local variables for split_port()
@d11wtq
d11wtq
commented
Aug 27, 2014

Copy link


Copy Markdown

Awesome. Good to see this. Thanks for all your contributions, @dnephin! Massively appreciated.
@dnephindnephin
mentioned this pull request
Aug 27, 2014

Closed

@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
9abdf34 to
be67aa7CompareAugust 28, 2014 03:32
@dnephindnephin
mentioned this pull request
Aug 28, 2014

Closed

7 tasks
@dnephin
Resolvesdocker#260,docker#301anddocker#449
07fa169
Adds ~ support and ro mode support for volumes, along with some additional validation.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
Some additional validation for container ports, and a couple extra te…
24044fa
…st cases.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
be67aa7 to
24044faCompareAugust 31, 2014 06:03
@dnephin
dnephin
commented
Aug 31, 2014

Copy link


Copy Markdown

Author
additional validation for mode (should be in ro, rw).
@bfirsh
bfirsh
commented
Sep 4, 2014

Copy link


Copy Markdown

LGTM

1 similar comment

@aanand
aanand
commented
Sep 4, 2014

Copy link


Copy Markdown

LGTM
aanand added a commit
that referenced
this pull request
Sep 4, 2014
@aanand
Merge pull request#442from dnephin/fix_create_container_volumes
7ad91f3
Additional validation for container volumes and ports.
@aanand
aanand
merged commit 7ad91f3
into
docker:masterSep 4, 2014
@dnephin
dnephin
deleted the

fix_create_container_volumes

branch
September 5, 2014 01:59
yuval-k pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
@aanand
Merge pull requestdocker#442from dnephin/fix_create_container_volumes
0232a7c
Additional validation for container volumes and ports.
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Is it possible to assign a volume name using an environment variable?

~ in volume path

Error when specifying permission in volume


5 participants

@dnephin@aanand@d11wtq@bfirsh@nathanleclaire

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Additional validation for container volumes and ports. by dnephin · Pull Request #442 · docker/compose · GitHub
Skip to content
Additional validation for container volumes and ports. - #442
Merged
aanand merged 3 commits into
docker:masterfrom 
dnephin:fix_create_container_volumes
Sep 4, 2014
Merged
Additional validation for container volumes and ports.#442
aanand merged 3 commits into
docker:masterfrom 
dnephin:fix_create_container_volumes
Conversation
@dnephin
@dnephindnephin
commented
Aug 24, 2014

Copy link


Copy Markdown

dnephin
dnephin
reviewed
Aug 24, 2014
 View reviewed changes

Comment threaddocs/yml.md
@dnephindnephinAug 24, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen multiple people confused about this so I tried to clarify that this is only an issue on OSX, not linux.
@nathanleclairenathanleclaireAug 27, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@dnephindnephin
mentioned this pull request
Aug 26, 2014
 Closed

aanand
aanand
reviewed
Aug 26, 2014
 View reviewed changes

Comment threadfig/service.py
Outdated

@aanandaanandAug 26, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list-fiddling stuff is really confusing. Could we bring back the local variables, so I can see what's being returned in each case?
@dnephindnephinAug 26, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm happy to make some changes here. I think in order to validate the string properly, we still need to make it a list, but additional local variables I can add.
@aanand
aanand
commented
Aug 26, 2014

Copy link


Copy Markdown

Sorry I missed this. Looks good.
Could it be split out into several logical commits? A lot of things are conflated here.
@dnephin
dnephin
commented
Aug 26, 2014

Copy link


Copy Markdown

Author
Sure, I'm definitely happy to split this into a few commits.
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
26a6e18 to
a813717CompareAugust 26, 2014 02:18
@dnephin
Fix the return value of get_tty_width() it should return an int.
8157f08
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
a813717 to
9abdf34CompareAugust 26, 2014 02:20
@dnephin
dnephin
commented
Aug 26, 2014

Copy link


Copy Markdown

Author
Rebased into three commits, and added additional local variables for split_port()
@d11wtq
d11wtq
commented
Aug 27, 2014

Copy link


Copy Markdown

Awesome. Good to see this. Thanks for all your contributions, @dnephin! Massively appreciated.
@dnephindnephin
mentioned this pull request
Aug 27, 2014

Closed

@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
9abdf34 to
be67aa7CompareAugust 28, 2014 03:32
@dnephindnephin
mentioned this pull request
Aug 28, 2014

Closed

7 tasks
@dnephin
Resolvesdocker#260,docker#301anddocker#449
07fa169
Adds ~ support and ro mode support for volumes, along with some additional validation.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
Some additional validation for container ports, and a couple extra te…
24044fa
…st cases.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
be67aa7 to
24044faCompareAugust 31, 2014 06:03
@dnephin
dnephin
commented
Aug 31, 2014

Copy link


Copy Markdown

Author
additional validation for mode (should be in ro, rw).
@bfirsh
bfirsh
commented
Sep 4, 2014

Copy link


Copy Markdown

LGTM

1 similar comment

@aanand
aanand
commented
Sep 4, 2014

Copy link


Copy Markdown

LGTM
aanand added a commit
that referenced
this pull request
Sep 4, 2014
@aanand
Merge pull request#442from dnephin/fix_create_container_volumes
7ad91f3
Additional validation for container volumes and ports.
@aanand
aanand
merged commit 7ad91f3
into
docker:masterSep 4, 2014
@dnephin
dnephin
deleted the

fix_create_container_volumes

branch
September 5, 2014 01:59
yuval-k pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
@aanand
Merge pull requestdocker#442from dnephin/fix_create_container_volumes
0232a7c
Additional validation for container volumes and ports.
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Is it possible to assign a volume name using an environment variable?

~ in volume path

Error when specifying permission in volume


5 participants

@dnephin@aanand@d11wtq@bfirsh@nathanleclaire

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Additional validation for container volumes and ports. by dnephin · Pull Request #442 · docker/compose · GitHub
Skip to content
Additional validation for container volumes and ports. - #442
Merged
aanand merged 3 commits into
docker:masterfrom 
dnephin:fix_create_container_volumes
Sep 4, 2014
Merged
Additional validation for container volumes and ports.#442
aanand merged 3 commits into
docker:masterfrom 
dnephin:fix_create_container_volumes
Conversation
@dnephin
@dnephindnephin
commented
Aug 24, 2014

Copy link


Copy Markdown

dnephin
dnephin
reviewed
Aug 24, 2014
 View reviewed changes

Comment threaddocs/yml.md
@dnephindnephinAug 24, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen multiple people confused about this so I tried to clarify that this is only an issue on OSX, not linux.
@nathanleclairenathanleclaireAug 27, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@dnephindnephin
mentioned this pull request
Aug 26, 2014
 Closed

aanand
aanand
reviewed
Aug 26, 2014
 View reviewed changes

Comment threadfig/service.py
Outdated

@aanandaanandAug 26, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list-fiddling stuff is really confusing. Could we bring back the local variables, so I can see what's being returned in each case?
@dnephindnephinAug 26, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm happy to make some changes here. I think in order to validate the string properly, we still need to make it a list, but additional local variables I can add.
@aanand
aanand
commented
Aug 26, 2014

Copy link


Copy Markdown

Sorry I missed this. Looks good.
Could it be split out into several logical commits? A lot of things are conflated here.
@dnephin
dnephin
commented
Aug 26, 2014

Copy link


Copy Markdown

Author
Sure, I'm definitely happy to split this into a few commits.
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
26a6e18 to
a813717CompareAugust 26, 2014 02:18
@dnephin
Fix the return value of get_tty_width() it should return an int.
8157f08
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
a813717 to
9abdf34CompareAugust 26, 2014 02:20
@dnephin
dnephin
commented
Aug 26, 2014

Copy link


Copy Markdown

Author
Rebased into three commits, and added additional local variables for split_port()
@d11wtq
d11wtq
commented
Aug 27, 2014

Copy link


Copy Markdown

Awesome. Good to see this. Thanks for all your contributions, @dnephin! Massively appreciated.
@dnephindnephin
mentioned this pull request
Aug 27, 2014

Closed

@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
9abdf34 to
be67aa7CompareAugust 28, 2014 03:32
@dnephindnephin
mentioned this pull request
Aug 28, 2014

Closed

7 tasks
@dnephin
Resolvesdocker#260,docker#301anddocker#449
07fa169
Adds ~ support and ro mode support for volumes, along with some additional validation.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
Some additional validation for container ports, and a couple extra te…
24044fa
…st cases.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
be67aa7 to
24044faCompareAugust 31, 2014 06:03
@dnephin
dnephin
commented
Aug 31, 2014

Copy link


Copy Markdown

Author
additional validation for mode (should be in ro, rw).
@bfirsh
bfirsh
commented
Sep 4, 2014

Copy link


Copy Markdown

LGTM

1 similar comment

@aanand
aanand
commented
Sep 4, 2014

Copy link


Copy Markdown

LGTM
aanand added a commit
that referenced
this pull request
Sep 4, 2014
@aanand
Merge pull request#442from dnephin/fix_create_container_volumes
7ad91f3
Additional validation for container volumes and ports.
@aanand
aanand
merged commit 7ad91f3
into
docker:masterSep 4, 2014
@dnephin
dnephin
deleted the

fix_create_container_volumes

branch
September 5, 2014 01:59
yuval-k pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
@aanand
Merge pull requestdocker#442from dnephin/fix_create_container_volumes
0232a7c
Additional validation for container volumes and ports.
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Is it possible to assign a volume name using an environment variable?

~ in volume path

Error when specifying permission in volume


5 participants

@dnephin@aanand@d11wtq@bfirsh@nathanleclaire

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Additional validation for container volumes and ports. by dnephin · Pull Request #442 · docker/compose · GitHub
Skip to content
Additional validation for container volumes and ports. - #442
Merged
aanand merged 3 commits into
docker:masterfrom 
dnephin:fix_create_container_volumes
Sep 4, 2014
Merged
Additional validation for container volumes and ports.#442
aanand merged 3 commits into
docker:masterfrom 
dnephin:fix_create_container_volumes
Conversation
@dnephin
@dnephindnephin
commented
Aug 24, 2014

Copy link


Copy Markdown

dnephin
dnephin
reviewed
Aug 24, 2014
 View reviewed changes

Comment threaddocs/yml.md
@dnephindnephinAug 24, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen multiple people confused about this so I tried to clarify that this is only an issue on OSX, not linux.
@nathanleclairenathanleclaireAug 27, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@dnephindnephin
mentioned this pull request
Aug 26, 2014
 Closed

aanand
aanand
reviewed
Aug 26, 2014
 View reviewed changes

Comment threadfig/service.py
Outdated

@aanandaanandAug 26, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list-fiddling stuff is really confusing. Could we bring back the local variables, so I can see what's being returned in each case?
@dnephindnephinAug 26, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm happy to make some changes here. I think in order to validate the string properly, we still need to make it a list, but additional local variables I can add.
@aanand
aanand
commented
Aug 26, 2014

Copy link


Copy Markdown

Sorry I missed this. Looks good.
Could it be split out into several logical commits? A lot of things are conflated here.
@dnephin
dnephin
commented
Aug 26, 2014

Copy link


Copy Markdown

Author
Sure, I'm definitely happy to split this into a few commits.
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
26a6e18 to
a813717CompareAugust 26, 2014 02:18
@dnephin
Fix the return value of get_tty_width() it should return an int.
8157f08
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
a813717 to
9abdf34CompareAugust 26, 2014 02:20
@dnephin
dnephin
commented
Aug 26, 2014

Copy link


Copy Markdown

Author
Rebased into three commits, and added additional local variables for split_port()
@d11wtq
d11wtq
commented
Aug 27, 2014

Copy link


Copy Markdown

Awesome. Good to see this. Thanks for all your contributions, @dnephin! Massively appreciated.
@dnephindnephin
mentioned this pull request
Aug 27, 2014

Closed

@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
9abdf34 to
be67aa7CompareAugust 28, 2014 03:32
@dnephindnephin
mentioned this pull request
Aug 28, 2014

Closed

7 tasks
@dnephin
Resolvesdocker#260,docker#301anddocker#449
07fa169
Adds ~ support and ro mode support for volumes, along with some additional validation.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
Some additional validation for container ports, and a couple extra te…
24044fa
…st cases.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
dnephinforce-pushed
the
fix_create_container_volumes
branch
from
be67aa7 to
24044faCompareAugust 31, 2014 06:03
@dnephin
dnephin
commented
Aug 31, 2014

Copy link


Copy Markdown

Author
additional validation for mode (should be in ro, rw).
@bfirsh
bfirsh
commented
Sep 4, 2014

Copy link


Copy Markdown

LGTM

1 similar comment

@aanand
aanand
commented
Sep 4, 2014

Copy link


Copy Markdown

LGTM
aanand added a commit
that referenced
this pull request
Sep 4, 2014
@aanand
Merge pull request#442from dnephin/fix_create_container_volumes
7ad91f3
Additional validation for container volumes and ports.
@aanand
aanand
merged commit 7ad91f3
into
docker:masterSep 4, 2014
@dnephin
dnephin
deleted the

fix_create_container_volumes

branch
September 5, 2014 01:59
yuval-k pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
@aanand
Merge pull requestdocker#442from dnephin/fix_create_container_volumes
0232a7c
Additional validation for container volumes and ports.
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Is it possible to assign a volume name using an environment variable?

~ in volume path

Error when specifying permission in volume


5 participants

@dnephin@aanand@d11wtq@bfirsh@nathanleclaire