Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

Don't package runc for RHEL/CentOS >= 8 - #272

Closed
Romain-Geissler-1A wants to merge 1 commit into
docker:mainfrom
Romain-Geissler-1A:dont-package-runc-for-rhel
Closed

Don't package runc for RHEL/CentOS >= 8#272
Romain-Geissler-1A wants to merge 1 commit into
docker:mainfrom
Romain-Geissler-1A:dont-package-runc-for-rhel

Conversation

@Romain-Geissler-1A

@Romain-Geissler-1ARomain-Geissler-1A commented Mar 9, 2022

Copy link
Copy Markdown
Contributor

Contains 2 commits. The first one is the commit adding CentOS 9 which I expect you will merge soon (#270).

The second commit is largely inspired by what @goeranu wrote in #231 and is the real purpose of this pull request: stop packaging runc for RHEL/CentOS >= 8, as Red Hat already packages it and it conflicts with the existing containerd.io packages.

@Romain-Geissler-1A
Romain-Geissler-1Aforce-pushed the dont-package-runc-for-rhel branch from 2b348f6 to be450a0CompareMarch 9, 2022 00:24
@Romain-Geissler-1ARomain-Geissler-1A changed the title Dont package runc for rhelDon't package runc for RHEL/CentOS >= 8Mar 9, 2022
@Romain-Geissler-1ARomain-Geissler-1A mentioned this pull request Mar 9, 2022
Closed
@Romain-Geissler-1A
Romain-Geissler-1Aforce-pushed the dont-package-runc-for-rhel branch from be450a0 to 8d03a90CompareMarch 9, 2022 01:07
@Romain-Geissler-1ARomain-Geissler-1A mentioned this pull request Mar 17, 2022
Closed
@Romain-Geissler-1A
Romain-Geissler-1Aforce-pushed the dont-package-runc-for-rhel branch 2 times, most recently from 913c7d7 to 94d3f5dCompareMay 4, 2022 21:17
@Romain-Geissler-1A

Romain-Geissler-1A commented May 4, 2022

Copy link
Copy Markdown
ContributorAuthor

@thaJeztah I have rebased/updated this pull request adopting the style you used in #283.

@Romain-Geissler-1A

Romain-Geissler-1A commented May 5, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Arg... again a build failure, and I can't see the logs, so I don't know what's wrong... When I try locally on my x86_64 machine it works for centos 7, 8 and 9, fedora 36 and leap 15. I have not tried other build targets (I tried only make $NAME_OF_BASE_OS_IMAGE).

@rumpl

rumpl commented May 5, 2022

Copy link
Copy Markdown
Member

It's an unrelated error:

#13 16.99 Fetched 70.4 MB in 7s (10.8 MB/s)
#13 16.99 E: Failed to fetch http://archive.raspbian.org/raspbian/pool/main/libi/libio-html-perl/libio-html-perl_1.001-1_all.deb Undetermined Error [IP: 93.93.128.191 80]
#13 16.99 E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

I restarted the build

@Romain-Geissler-1A
Don't package runc for RHEL/CentOS >= 8
1774abf
Signed-off-by: Romain Geissler <romain.geissler@amadeus.com>
@Romain-Geissler-1A
Romain-Geissler-1Aforce-pushed the dont-package-runc-for-rhel branch from 94d3f5d to 1774abfCompareMay 5, 2022 22:04
This was referenced May 6, 2022
Closed
Closed
@Romain-Geissler-1A

Romain-Geissler-1A commented May 16, 2022

Copy link
Copy Markdown
ContributorAuthor

Ping

@Romain-Geissler-1ARomain-Geissler-1A mentioned this pull request May 21, 2022
Open
@Romain-Geissler-1A

Romain-Geissler-1A commented May 23, 2022

Copy link
Copy Markdown
ContributorAuthor

Ping

5 similar comments
@Romain-Geissler-1A

Romain-Geissler-1A commented Jun 7, 2022

Copy link
Copy Markdown
ContributorAuthor

Ping

@Romain-Geissler-1A

Romain-Geissler-1A commented Jun 20, 2022

Copy link
Copy Markdown
ContributorAuthor

Ping

@Romain-Geissler-1A

Romain-Geissler-1A commented Jun 27, 2022

Copy link
Copy Markdown
ContributorAuthor

Ping

@Romain-Geissler-1A

Romain-Geissler-1A commented Jul 15, 2022

Copy link
Copy Markdown
ContributorAuthor

Ping

@Romain-Geissler-1A

Romain-Geissler-1A commented Jul 29, 2022

Copy link
Copy Markdown
ContributorAuthor

Ping

AkihiroSuda
AkihiroSuda reviewed Aug 16, 2022
View reviewed changes
Comment threadrpm/containerd.spec
Name: containerd.io
Provides: containerd
# For some reason on rhel >= 8 if we "provide" runc then it makes this package unsearchable
# On RHEL >= 8, runc is packaged by Red Hat so it won't be provided by this package.

@AkihiroSudaAkihiroSudaAug 16, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to generate runc rpm too, to override the Red Hat version?

cc @thaJeztah@kolyshkin WDYT?

@goeranugoeranuAug 16, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make a separate runc package when there already exist a native one? Isn't it better to use the OS version when there is one?

@AkihiroSudaAkihiroSudaAug 16, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OS version is often outdated

@thaJeztah

thaJeztah commented May 21, 2026

Copy link
Copy Markdown
Member

👋 I'm closing this PR, because packaging of containerd moved to https://github.com/docker/packaging/tree/main/pkg/containerd, so we'll be archiving this one.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@goeranugoeranugoeranu left review comments
@AkihiroSudaAkihiroSudaAkihiroSuda left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Romain-Geissler-1A@rumpl@thaJeztah@goeranu@AkihiroSuda