Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

Also build for CentOS 9. - #283

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:carry_270_centos9
May 4, 2022
Merged

Also build for CentOS 9.#283
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:carry_270_centos9

Conversation

@thaJeztah

@thaJeztahthaJeztah commented May 4, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Changes;

  • do not "provide" runc on CentOS/RHEL >= 8
  • do not build btrfs on CentOS/RHEL >= 8
  • set the correct build-dependency for BTRFS on SUSE flavors and "others"

thaJeztah
thaJeztah commented May 4, 2022
View reviewed changes
Comment threadrpm/containerd.spec Outdated
thaJeztah
thaJeztah commented May 4, 2022
View reviewed changes
Comment threadrpm/containerd.spec Outdated
@thaJeztah
thaJeztahforce-pushed the carry_270_centos9 branch 7 times, most recently from 64ec306 to 3fa047dCompareMay 4, 2022 16:16
@Romain-Geissler-1A@thaJeztah
Also build for CentOS 9.
7913b5b
- do not "provide" runc on CentOS/RHEL >= 8
- do not build btrfs on CentOS/RHEL >= 8
- set the correct build-dependency for BTRFS on SUSE flavors and "others"
Signed-off-by: Romain Geissler <romain.geissler@amadeus.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztah marked this pull request as ready for review May 4, 2022 16:49
@thaJeztahthaJeztah mentioned this pull request May 4, 2022
Closed
@thaJeztah

thaJeztah commented May 4, 2022

Copy link
Copy Markdown
MemberAuthor

@ndeloof@tianon@rumpl PTAL; I think this one should be ready for review

@Romain-Geissler-1A

Romain-Geissler-1A commented May 4, 2022

Copy link
Copy Markdown
Contributor

Hi,

For what it's worth, these changes look ok for me.

Cheers,
Romain

tianon
tianon approved these changes May 4, 2022
View reviewed changes

@tianontianon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit over my head on RPM spec knowledge, but seems sane? 🙈

@thaJeztah

thaJeztah commented May 4, 2022

Copy link
Copy Markdown
MemberAuthor

Hi,

For what it's worth, these changes look ok for me.

Cheers, Romain

Thank you, Romain!

A bit over my head on RPM spec knowledge, but seems sane?

They're a big pain, so don't blame you (took me several attempts to get it right with all the different distro combinations 😓)

@thaJeztah

thaJeztah commented May 4, 2022

Copy link
Copy Markdown
MemberAuthor

Let me bring this one in 👍

@thaJeztah
thaJeztah merged commit e773c4e into docker:masterMay 4, 2022
@thaJeztah
thaJeztah deleted the carry_270_centos9 branch May 4, 2022 17:02
This was referenced May 4, 2022
Closed
Merged
alunsin pushed a commit to alunsin/docker-ce-build that referenced this pull request May 6, 2022
Aurelien Lun-Sin
Fix centOS 9 Stream
6c2c805
See docker/containerd-packaging#283
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@tianontianontianon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah@Romain-Geissler-1A@tianon