Skip to content

fix: Can't search homepage content - #1391

Merged
sy-records merged 4 commits into
docsifyjs:developfrom
sy-records:fix-search
Oct 14, 2020
Merged

fix: Can't search homepage content#1391
sy-records merged 4 commits into
docsifyjs:developfrom
sy-records:fix-search

Conversation

@sy-records

@sy-recordssy-records commented Oct 12, 2020

Copy link
Copy Markdown
Member

Summary

fix#1080

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@vercel

vercelBot commented Oct 12, 2020•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/gcnf2rmjl
✅ Preview: https://docsify-preview-git-fix-search.docsify-core.vercel.app

@codesandbox-ci

codesandbox-ciBot commented Oct 12, 2020•
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a7a81d7:

SandboxSource
docsify-templateConfiguration

@Koooooo-7

Koooooo-7 commented Oct 13, 2020

Copy link
Copy Markdown
Member

I hvnt understood where the issue/bug is yet. 😅
Could u do me a flavor that showing some pics or reproduce steps.

@sy-records

sy-records commented Oct 13, 2020

Copy link
Copy Markdown
MemberAuthor

For example, site generator cannot be searched

It is in the readme.

anikethsaha
anikethsaha approved these changes Oct 14, 2020
View reviewed changes

@anikethsahaanikethsaha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS

@sy-records
sy-records merged commit 25bc9b7 into docsifyjs:developOct 14, 2020
@sy-records
sy-records deleted the fix-search branch October 14, 2020 04:40
Koooooo-7 pushed a commit to Koooooo-7/docsify that referenced this pull request Oct 15, 2020
@sy-records@Koooooo-7
fix: Can't search homepage content (docsifyjs#1391)
9bfac00
* fix: Can't search homepage content
* fix: when pathNamespaces does not exist
* add test
* update test to fix windows ci
trusktr added a commit that referenced this pull request Nov 2, 2020
@trusktr
Merge branch 'develop' into fix-validating-remote-content
d516198
* develop: (81 commits)
fix: upgrade dompurify from 2.1.0 to 2.1.1 (#1402)
fix: upgrade dompurify from 2.0.17 to 2.1.0 (#1397)
fix: search on homepage test (#1398)
fix: the sidebar links to another site. (#1336)
fix: Can't search homepage content (#1391)
fix: upgrade debug from 4.1.1 to 4.3.0 (#1390)
fix: packages/docsify-server-renderer/package.json & packages/docsify-server-renderer/package-lock.json to reduce vulnerabilities (#1389)
Fix eslint warnings (#1388)
docs: add crossOriginLinks configurations details. (#1386)
Remove Cypress screenshots
Fix friendly message display
Add Vue 3 compatibility
Show dir listing & help msg for manual instance
Add NODE_MODULES_URL global
Jest + Playwright Testing (#1276)
update doc (#1381)
Fix scroll event end value
fix: upgrade docsify from 4.11.4 to 4.11.6 (#1373)
chore(deps): bump node-fetch in /packages/docsify-server-renderer (#1370)
test: fix cannot search list content (#1367)
...
@sy-recordssy-records mentioned this pull request Nov 19, 2020
Closed
1 task
@sy-recordssy-records mentioned this pull request Feb 5, 2021
Merged
3 tasks
This was referenced Mar 9, 2021
Merged
Open
Closed
Merged
@dependabotdependabotBot mentioned this pull request Mar 17, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anikethsahaanikethsahaanikethsaha approved these changes
@Koooooo-7Koooooo-7Koooooo-7 approved these changes
@jhildenbiddlejhildenbiddleAwaiting requested review from jhildenbiddle
@trusktrtrusktrAwaiting requested review from trusktr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search does not work on the home page

4 participants

@sy-records@Koooooo-7@anikethsaha@trusktr