Skip to content

fix: search on homepage test - #1398

Merged
sy-records merged 8 commits into
docsifyjs:developfrom
sy-records:fix-ci
Oct 15, 2020
Merged

fix: search on homepage test#1398
sy-records merged 8 commits into
docsifyjs:developfrom
sy-records:fix-ci

Conversation

@sy-records

@sy-recordssy-records commented Oct 15, 2020

Copy link
Copy Markdown
Member

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@vercel

vercelBot commented Oct 15, 2020•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/3owxcn697
✅ Preview: https://docsify-preview-git-fix-ci.docsify-core.vercel.app

@codesandbox-ci

codesandbox-ciBot commented Oct 15, 2020•
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5a4cea6:

SandboxSource
docsify-templateConfiguration

anikethsaha
anikethsaha previously approved these changes Oct 15, 2020
View reviewed changes
@sy-recordssy-records changed the title fix: ci buildfix: search on homepage testOct 15, 2020
Koooooo-7
Koooooo-7 previously approved these changes Oct 15, 2020
View reviewed changes
@sy-recordssy-records mentioned this pull request Oct 15, 2020
Merged
19 tasks
jhildenbiddle
jhildenbiddle approved these changes Oct 15, 2020
View reviewed changes

@jhildenbiddlejhildenbiddle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added multi-page search tests.

jhildenbiddle
jhildenbiddle requested changes Oct 15, 2020
View reviewed changes

@jhildenbiddlejhildenbiddle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing the search plugin, not the sidebar. Consider renaming this file to something more appropriate like plugin-search.test.js.

@sy-records

sy-records commented Oct 15, 2020

Copy link
Copy Markdown
MemberAuthor

You're right.

@sy-records
sy-records merged commit ee550d0 into docsifyjs:developOct 15, 2020
@sy-records
sy-records deleted the fix-ci branch October 15, 2020 09:41
sy-records added a commit to sy-records/docsify that referenced this pull request Oct 15, 2020
@sy-records@jhildenbiddle
fix: search on homepage test (docsifyjs#1398)
2620359
* fix: ci build
* reset
* test
* update
* fix test
* fix
* Add multi-page search test
* rename
Co-authored-by: John Hildenbiddle <jhildenbiddle@users.noreply.github.com>
trusktr added a commit that referenced this pull request Nov 2, 2020
@trusktr
Merge branch 'develop' into fix-validating-remote-content
d516198
* develop: (81 commits)
fix: upgrade dompurify from 2.1.0 to 2.1.1 (#1402)
fix: upgrade dompurify from 2.0.17 to 2.1.0 (#1397)
fix: search on homepage test (#1398)
fix: the sidebar links to another site. (#1336)
fix: Can't search homepage content (#1391)
fix: upgrade debug from 4.1.1 to 4.3.0 (#1390)
fix: packages/docsify-server-renderer/package.json & packages/docsify-server-renderer/package-lock.json to reduce vulnerabilities (#1389)
Fix eslint warnings (#1388)
docs: add crossOriginLinks configurations details. (#1386)
Remove Cypress screenshots
Fix friendly message display
Add Vue 3 compatibility
Show dir listing & help msg for manual instance
Add NODE_MODULES_URL global
Jest + Playwright Testing (#1276)
update doc (#1381)
Fix scroll event end value
fix: upgrade docsify from 4.11.4 to 4.11.6 (#1373)
chore(deps): bump node-fetch in /packages/docsify-server-renderer (#1370)
test: fix cannot search list content (#1367)
...
This was referenced Mar 9, 2021
Merged
Open
Closed
Merged
@dependabotdependabotBot mentioned this pull request Mar 17, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhildenbiddlejhildenbiddlejhildenbiddle approved these changes
@Koooooo-7Koooooo-7Koooooo-7 approved these changes
@trusktrtrusktrAwaiting requested review from trusktr
@anikethsahaanikethsahaAwaiting requested review from anikethsaha

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sy-records@jhildenbiddle@anikethsaha@Koooooo-7