Skip to content

[3.0] Improve generator performance - #2567

Merged
Exanite merged 25 commits into
dotnet:develop/3.0from
Exanite:feature/performance
Apr 18, 2026
Merged

[3.0] Improve generator performance#2567
Exanite merged 25 commits into
dotnet:develop/3.0from
Exanite:feature/performance

Conversation

@Exanite

@ExaniteExanite commented Apr 13, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Summary of the PR

This branch will be where I investigate performance improvements to the Silk 3.0 bindings generator.

Related issues, Discord discussions, or proposals

Discord thread for discussing development: https://discord.com/channels/521092042781229087/1493337581805371432

Further Comments

Tasks

  • Update ClangSharp
  • Optimize renamer
    • Track relevant identifiers and only resolve symbols for relevant identifiers instead of for all identifiers
  • Optimize PrettifyNames
    • Optimize document rename path conflict detection
  • Consider removing NormalizeWhitespace calls where possible
  • Investigate ContainsAny calls, particularly when called by TryParseNativeTypeName. This shows up as a hotspot during profiling.
    • Not worth optimizing (will improve only by ~100 ms and worsens code maintainability)
    • Also likely to not affect the Microsoft bindings
  • Consider removing ModCSharpSyntaxRewriter
  • Regenerate all bindings on Windows to ensure no changes

Exanite added 12 commits April 14, 2026 19:08
@Exanite
Update ClangSharp.PInvokeGenerator
7938a0c
@Exanite
Update comment on ModifyAllReferencesAsync in TransformHandles
78b8ec4
@Exanite
Format files using CSharpier
a11ef49
These were written before I installed the CSharpier plugin so they were not formatted.
@Exanite
Remove GetTypeInfo call
9cf0637
GetTypeInfo should be unnecessary since it gets the type of an expression.
For non-type expressions (eg: `5` is an int), this isn't useful for us.
This is arguably an indirect reference to int, but the current Silk generator only cares about modifying direct references.
For type expressions (eg: `int` refers to int), GetSymbolInfo will also return the same symbol.
@Exanite
Get the compilation once*
8c05ec7
*Roslyn already caches this internally. This is mainly for avoiding the async method call.
Difference is probably not measurable, but theoretically this is faster.
@Exanite
Compare against _relevantIdentifiers set before calling GetSymbolInfo
fe50783
@Exanite
Skip using directives
9cb75e1
@Exanite
Add ProfilingScope
5638221
@Exanite
Add comment on _relevantIdentifiers
a0ea115
@Exanite
Fix field naming convention in ProfilingScope
ed941db
@Exanite
Optimize document renaming in PrettifyNames
8d5b978
Conflict checking was O(n), now it is O(1).
@Exanite
Use normalized relative paths during conflict checking
878a90f
This is to prevent false negatives from mismatched path formats.
@Exanite
Exaniteforce-pushed the feature/performance branch from a934c2b to 878a90fCompareApril 14, 2026 23:09
@Exanite
Remove NormalizeWhitespace calls (much faster, but breaks generator)
9d52a44
(cherry picked from commit 8cf1324)
@Exanite
Fix issue where the syntax tree gets corrupted due to reparsing
aaafeff
(cherry picked from commit 2c48fb6)
@Exanite
Edit comment and error message
f63b15a
(cherry picked from commit 6b12c69)
@Exanite
Avoid normalizing the syntax node twice when formatting
46c2035
@Exanite
Avoid rebuilding the _relevantIdentifiers set for every document
0d81c61
@Exanite
Move collections in ResolveConflictsProcessor to be closer to where t…
bd2d79c
…hey are used
@Exanite
Preserve original line ending behavior
364015d
(cherry picked from commit 66d0daa)
@Exanite
Update SDL to v3.44 from v3.2.4 to fix compile error
00d83bc
@Exanite
Revert change to get the compilation once during ModifyAllReferencesA…
aa13c48
…sync
This change caused incorrect behavior since the document ids can come from projects other than the source project (namely the test project).
This broken when semantic models were requested for test project documents from the source project compilation.
This was referenced Apr 17, 2026
Closed
Merged
@Exanite
Exaniteforce-pushed the feature/performance branch from 9ab6f5b to 07e05f0CompareApril 17, 2026 22:07
Exanite
Exanite commented Apr 17, 2026
View reviewed changes

@ExaniteExanite left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self code review complete. My review comments point out why things are changed, but the code should make sense without them.

I've also regenerated the bindings using Windows to verify that no output changes have occurred.

Comment threadsources/SilkTouch/SilkTouch/Profiling/ProfilingScope.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/TransformHandles.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/PrettifyNames.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/PrettifyNames.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/PrettifyNames.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/ChangeNamespace.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/Common/MSBuildModContext.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/LocationTransformation/IdentifierRenamingTransformer.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/LocationTransformation/LocationTransformationUtils.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/LocationTransformation/LocationTransformationRewriter.cs
@Exanite
Exanite marked this pull request as ready for review April 17, 2026 22:30
@Exanite
Exanite requested a review from a team as a code ownerApril 17, 2026 22:30
@Exanite
Exanite merged commit 133c257 into dotnet:develop/3.0Apr 18, 2026
19 checks passed
@Exanite
Exanite deleted the feature/performance branch April 18, 2026 02:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curincurincurin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Silk.NET Development Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Exanite@curin