Uh oh!
There was an error while loading. Please reload this page.
[3.0] Update SDL and ClangSharp - #2570
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against ad14c0e |
8622118 to
dc21675CompareCMAKE_LIBRARY_ARCHITECTURE fixes the issue where system libraries weren't being found. Eg: "SDL_X11 (Wanted: ON): ON" was OFF without this setting. Eg: "Found OpenGL: /usr/lib/x86_64-linux-gnu/libOpenGL.so " was a not found error without this setting. I removed the pkg-config settings since they didn't seem to do anything and I couldn't figure out if they were correct in the first place. I'm assuming CMake figures these out automatically (it should automatically find the host version of the pkg-config executable and I'm *assuming* (please verify) it uses the CMAKE_LIBRARY_ARCHITECTURE variable to figure out which set of .pc files to use).
x64/amd64 is handled the same way for consistency.
…x package resolution issues
All native library builds modified in this PR shall attempt to be built by CI. |
(cherry picked from commit ecc5677)
…e, but dependencies first by default is most consistent) (cherry picked from commit ad2d940)
…'s native build process
apt-get seems to be recommended over apt for scripting purposes. apt is designed for humans and does not guarantee backwards compatibility. See https://manpages.debian.org/stretch/apt/apt.8.en.html
Some of the native library builds modified in this PR were not referenced in the PR description. Please ensure that the PR description contains |
Exanite
left a comment
There was a problem hiding this comment.
Self code review completed for the new changes I added.
Should be ready for review and merging now.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary of the PR
This PR updates ClangSharp and SDL. This was originally part of #2567, but proved to be a more involved change than anticipated due to SDL build problems.
Related issues, Discord discussions, or proposals
This will fix#2402
This PR should also be closed since this PR effectively supersedes it: #2433
Further Comments
Tasks
After merging:
Native builds
(Currently disabling this command by adding a space; the builds are already committed so there's no reason to run them again)
/ build-native SDL OpenAL-Soft