Uh oh!
There was an error while loading. Please reload this page.
Default InvariantGlobalization in Xamarin Android - #5605
Conversation
This allows for unnecessary code to be trimmed by default in an app. See dotnet/runtime#47999.
jonathanpeppers
commented
Feb 9, 2021
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonpryor
commented
Feb 10, 2021
@eerhardt : why isn't |
The behavior of
For app models that are trimmed (Blazor WASM, Xamarin), this setting allows the code that is only used when I made the same changes in Blazor WASM And @marek-safar requested I make the same change to Xamarin. |
radekdoulik
commented
Feb 10, 2021
Added |
radekdoulik
commented
Feb 10, 2021
Ah, but there will be no difference yet. We should bump net6 version too. |
radekdoulik
commented
Feb 10, 2021
I tried to measure it with |
This is no longer needed since dotnet/runtime#53453 fixed the issue this was working around. Bringing back the original optimization in dotnet#5605.
Context: #5954 (comment) Context: #5605 This partially reverts da536fc. In da536fc, we started seeing a crash around `$(InvariantGlobalization)`. This is no longer needed since dotnet/runtime#53453 fixed the issue. Bringing back the original optimization in #5605.
This allows for unnecessary code to be trimmed by default in an app. See dotnet/runtime#47999.