Skip to content

Remove InvariantGlobalization workaround - #6724

Merged
jonathanpeppers merged 1 commit into
dotnet:mainfrom
eerhardt:RemoveInvariantGlobalizationWorkaround
Feb 10, 2022
Merged

Remove InvariantGlobalization workaround#6724
jonathanpeppers merged 1 commit into
dotnet:mainfrom
eerhardt:RemoveInvariantGlobalizationWorkaround

Conversation

@eerhardt

Copy link
Copy Markdown
Member

This is no longer needed since dotnet/runtime#53453 fixed the issue this was working around.

Bringing back the original optimization in #5605.

This is no longer needed since dotnet/runtime#53453 fixed the issue this was working around.
Bringing back the original optimization in dotnet#5605.

@jonathanpeppersjonathanpeppers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks like da536fc#5954 was just working around a bug, and we never followed up.

Will just need to check the CI results.

@jonathanpeppers
jonathanpeppers merged commit 0b448ab into dotnet:mainFeb 10, 2022
@eerhardt
eerhardt deleted the RemoveInvariantGlobalizationWorkaround branch February 10, 2022 15:00
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 24, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@eerhardt@jonathanpeppers