Skip to content

[main] Update dependencies from dotnet/installer - #8131

Merged
jonathanpeppers merged 2 commits into
mainfrom
darc-main-d943fbcd-6905-4503-bfe1-c645d303a127
Jun 19, 2023
Merged

[main] Update dependencies from dotnet/installer#8131
jonathanpeppers merged 2 commits into
mainfrom
darc-main-d943fbcd-6905-4503-bfe1-c645d303a127

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Jun 16, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NETCore.App.Ref: from 8.0.0-preview.6.23307.4 to 8.0.0-preview.6.23316.3 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport: from 8.0.0-preview.6.23301.1 to 8.0.0-preview.6.23312.1 (parent: Microsoft.NETCore.App.Ref)
    • Microsoft.NET.ILLink.Tasks: from 8.0.0-preview.6.23307.4 to 8.0.0-preview.6.23316.3 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.DotNet.Cecil: from 0.11.4-alpha.23301.1 to 0.11.4-alpha.23312.1 (parent: Microsoft.NET.ILLink.Tasks)

From https://github.com/dotnet/installer

  • Subscription: 0ba14476-1d1a-452a-3b67-08da9690aef0
  • Build: 20230618.1
  • Date Produced: June 19, 2023 3:44:00 AM UTC
  • Commit: 8d98e5a6ba7f7fbc157ebea6317d8e7418472920
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/installerbuild 20…
d2a4ff8
…230616.23
Microsoft.Dotnet.Sdk.Internal
From Version 8.0.100-preview.6.23310.1 -> To Version 8.0.100-preview.6.23316.23
Dependency coherency updates
Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport,Microsoft.NET.ILLink.Tasks,Microsoft.DotNet.Cecil
From Version 8.0.0-preview.6.23307.4 -> To Version 8.0.0-preview.6.23316.2 (parent: Microsoft.Dotnet.Sdk.Internal
@jonathanpeppers

jonathanpeppers commented Jun 16, 2023

Copy link
Copy Markdown
Member

@fanyang-mono this looks like it has: dotnet/runtime#86722

@lewing

lewing commented Jun 16, 2023•
edited
Loading

Copy link
Copy Markdown
Member

I triggered this manually. The installer flow for main is currently set to weekly, which is probably lower than ideal. Daily seems like a better default. You wouldn't have to merge every flow pr but you would get fixes more quickly.

@lewing

lewing commented Jun 16, 2023

Copy link
Copy Markdown
Member

@jonathanpeppers this should have a fixed msbuild too I think

@jonathanpeppers

jonathanpeppers commented Jun 16, 2023

Copy link
Copy Markdown
Member

@lewing it usually takes longer than 1 day to merge one of these, so I normally trigger one mid-week. So we normally get twice-per-week bumps.

@jonathanpeppers

jonathanpeppers commented Jun 16, 2023

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelinesBot commented Jun 16, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lewing

lewing commented Jun 16, 2023

Copy link
Copy Markdown
Member

@lewing it usually takes longer than 1 day to merge one of these, so I normally trigger one mid-week. So we normally get twice-per-week bumps.

We generally let darc pull in new changes while we're working on merges but whatever works best you is what to do. Sometimes we don't get a new installer for a week so the delay can compound, I noticed it had been a while since the last one.

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/installerbuild 20…
19a4c8e
…230618.1
Microsoft.Dotnet.Sdk.Internal
From Version 8.0.100-preview.6.23310.1 -> To Version 8.0.100-preview.6.23318.1
Dependency coherency updates
Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport,Microsoft.NET.ILLink.Tasks,Microsoft.DotNet.Cecil
From Version 8.0.0-preview.6.23307.4 -> To Version 8.0.0-preview.6.23316.3 (parent: Microsoft.Dotnet.Sdk.Internal
jonathanpeppers
jonathanpeppers approved these changes Jun 19, 2023
View reviewed changes

@jonathanpeppersjonathanpeppers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can ignore the one test failure:

DesignTime build should be less than 10000 milliseconds.
Expected: less than or equal to 10000.0d
But was: 16910.0d

@jonathanpeppers
jonathanpeppers merged commit 0e72f32 into mainJun 19, 2023
@jonathanpeppers
jonathanpeppers deleted the darc-main-d943fbcd-6905-4503-bfe1-c645d303a127 branch June 19, 2023 19:32
grendello added a commit to grendello/xamarin-android that referenced this pull request Jun 20, 2023
@grendello
Merge branch 'main' into blazor-hang
76e4d0c
* main:
Bump to dotnet/installer@8d98e5a6ba 8.0.100-preview.6.23318.1 (dotnet#8131)
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 22, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonathanpeppersjonathanpeppersjonathanpeppers approved these changes
@pjcollinspjcollinsAwaiting requested review from pjcollins
@jonpryorjonpryorAwaiting requested review from jonpryor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonathanpeppers@lewing