Skip to content

[Mono] Add the capability of trimming IL code of individual methods - #86722

Merged
fanyang-mono merged 27 commits into
dotnet:mainfrom
fanyang-mono:il_trim_tool
Jun 16, 2023
Merged

[Mono] Add the capability of trimming IL code of individual methods#86722
fanyang-mono merged 27 commits into
dotnet:mainfrom
fanyang-mono:il_trim_tool

Conversation

@fanyang-mono

@fanyang-monofanyang-mono commented May 24, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Contributes to #44855

@jonathanpeppers After this is merged. It should be adoptable by Android. I have updated the HelloWorld sample as an example to showcase how to use this feature.

Usage of this feature:

  1. Enable AOT to log compiled methods. This could be achieved by setting CollectCompiledMethods and CompiledMethodsOutputDirectory for MonoAOTCompiler
  2. Run ILStrip after MonoAOTCompiler
  3. Overwrite the assemblies with the trimmed ones.

For more details, please refer to the HelloWorld sample app change included in this PR.

teo-tsirpanis
teo-tsirpanis reviewed May 24, 2023
View reviewed changes
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs Outdated
Comment on lines +47 to +49
int allowedParallelism = DisableParallelStripping ? 1 : Math.Min(Assemblies.Length, Environment.ProcessorCount);
if (BuildEngine is IBuildEngine9 be9)
allowedParallelism = be9.RequestCores(allowedParallelism);

@teo-tsirpanisteo-tsirpanisMay 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
intallowedParallelism=DisableParallelStripping?1:Math.Min(Assemblies.Length,Environment.ProcessorCount);
if(BuildEngineisIBuildEngine9be9)
allowedParallelism=be9.RequestCores(allowedParallelism);
intallowedParallelism=DisableParallelStripping?1:BuildEngine9.RequestCores(Math.Min(Assemblies.Length,Environment.ProcessorCount));

@fanyang-monofanyang-monoMay 26, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hit an error when applying your change

System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values.

Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs Outdated
Comment on lines +77 to +79
int allowedParallelism = DisableParallelStripping ? 1 : Math.Min(MethodTokenFiles.Length, Environment.ProcessorCount);
if (BuildEngine is IBuildEngine9 be9)
allowedParallelism = be9.RequestCores(allowedParallelism);

@teo-tsirpanisteo-tsirpanisMay 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
intallowedParallelism=DisableParallelStripping?1:Math.Min(MethodTokenFiles.Length,Environment.ProcessorCount);
if(BuildEngineisIBuildEngine9be9)
allowedParallelism=be9.RequestCores(allowedParallelism);
intallowedParallelism=DisableParallelStripping?1:BuildEngine9.RequestCores(Math.Min(Assemblies.Length,Environment.ProcessorCount));

This was referenced May 25, 2023
Closed
Closed
@fanyang-monofanyang-mono changed the title [WIP][Mono] Add the capability of trimming IL code of individual methods[Mono] Add the capability of trimming IL code of individual methodsMay 26, 2023
ivanpovazan
ivanpovazan reviewed May 29, 2023
View reviewed changes
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs Outdated
ivanpovazan
ivanpovazan reviewed May 29, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-compiler.c Outdated
ivanpovazan
ivanpovazan reviewed May 29, 2023
View reviewed changes
Comment threadsrc/mono/sample/HelloWorld/HelloWorld.csproj Outdated
ivanpovazan
ivanpovazan reviewed May 29, 2023
View reviewed changes
Comment threadsrc/mono/sample/HelloWorld/HelloWorld.csproj
ivanpovazan
ivanpovazan reviewed May 29, 2023
View reviewed changes
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
@ivanpovazan

ivanpovazan commented May 29, 2023

Copy link
Copy Markdown
Member

It would be nice to include a specification/documentation of how this feature is used/enabled (possibly with an example of MethodTokenFile). Might be enough to just include it in the PR description.

jonathanpeppers
jonathanpeppers reviewed May 30, 2023
View reviewed changes
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs Outdated
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs Outdated
vargaz
vargaz reviewed May 31, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-compiler.c Outdated
@build-analysisbuild-analysisBot mentioned this pull request May 31, 2023
Closed
@build-analysisbuild-analysisBot mentioned this pull request May 31, 2023
Closed
fanyang-monoand others added 7 commits June 5, 2023 17:55
@fanyang-mono@radical
Update src/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
78981c8
Co-authored-by: Ankit Jain <radical@gmail.com>
@fanyang-mono@radical
Update src/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
b519b4c
Co-authored-by: Ankit Jain <radical@gmail.com>
@fanyang-mono@radical
Update src/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
3322022
Co-authored-by: Ankit Jain <radical@gmail.com>
@fanyang-mono@radical
Update src/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
1a83902
Co-authored-by: Ankit Jain <radical@gmail.com>
@fanyang-mono@radical
Update src/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
f1b2753
Co-authored-by: Ankit Jain <radical@gmail.com>
@fanyang-mono@radical
Update src/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
328e9be
Co-authored-by: Ankit Jain <radical@gmail.com>
@fanyang-mono
Add more error handling
10226b7
radical
radical reviewed Jun 6, 2023
View reviewed changes
Comment threadsrc/tasks/AotCompilerTask/MonoAOTCompiler.cs Outdated
radical
radical requested changes Jun 12, 2023
View reviewed changes
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs Outdated
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs Outdated
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs Outdated
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs Outdated
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs Outdated
Comment threadsrc/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
@ghostghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 12, 2023
@build-analysisbuild-analysisBot mentioned this pull request Jun 13, 2023
Closed
@fanyang-mono@radical
Update src/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs
3aad84a
Co-authored-by: Ankit Jain <radical@gmail.com>
@ghostghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 13, 2023
@fanyang-monofanyang-mono mentioned this pull request Jun 13, 2023
Open
lambdageek
lambdageek approved these changes Jun 13, 2023
View reviewed changes

@lambdageeklambdageek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

radical
radical approved these changes Jun 13, 2023
View reviewed changes

@radicalradical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@build-analysisbuild-analysisBot mentioned this pull request Jun 15, 2023
Closed
@fanyang-mono

fanyang-mono commented Jun 16, 2023

Copy link
Copy Markdown
MemberAuthor

CI failures are not related to this PR.

@fanyang-mono
fanyang-mono merged commit 9fc19a1 into dotnet:mainJun 16, 2023
@jonathanpeppersjonathanpeppers mentioned this pull request Jun 16, 2023
Merged
jonathanpeppers added a commit to jonathanpeppers/xamarin-android that referenced this pull request Jul 6, 2023
@jonathanpeppers
[Xamarin.Android.Build.Tasks] implement $(AndroidStripIL)
815e374
Context: dotnet/runtime#86722
This adds an `<ILStrip/>` step after the `<MonoAOTCompiler/>` task.
This trims away IL of AOT-compiled methods. This is WIP.
Builds work currently, but the app crashes at runtime with:
07-06 16:57:07.413 8865 8865 E companyname.foo: * Assertion at /__w/1/s/src/mono/mono/mini/mini-trampolines.c:1416, condition `invoke' not met
This was referenced Jul 6, 2023
Merged
Closed
This was referenced Jul 11, 2023
Closed
Open
@ghostghost locked as resolved and limited conversation to collaborators Aug 6, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical approved these changes
@jonathanpeppersjonathanpeppersjonathanpeppers left review comments
@akoeplingerakoeplingerakoeplinger left review comments
@ivanpovazanivanpovazanivanpovazan left review comments
@lambdageeklambdageeklambdageek approved these changes
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@marek-safarmarek-safarAwaiting requested review from marek-safar
+2 more reviewers
@vargazvargazvargaz left review comments
@teo-tsirpanisteo-tsirpanisteo-tsirpanis left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@fanyang-monofanyang-mono

Labels

area-Codegen-AOT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@fanyang-mono@ivanpovazan@radical@vargaz@lambdageek@jonathanpeppers@akoeplinger@teo-tsirpanis