Uh oh!
There was an error while loading. Please reload this page.
[build] produce multiple "flavors" of runtime packs - #9538
Merged
Conversation
Right now our runtime packs are all identical for each .NET "runtime", but we want to be able to produce different packs, such as: Microsoft.Android.Runtime.Mono.35.android-arm Microsoft.Android.Runtime.Mono.35.android-arm64 Microsoft.Android.Runtime.Mono.35.android-x86 Microsoft.Android.Runtime.Mono.35.android-x64 Microsoft.Android.Runtime.NativeAOT.35.android-arm Microsoft.Android.Runtime.NativeAOT.35.android-arm64 Microsoft.Android.Runtime.NativeAOT.35.android-x86 Microsoft.Android.Runtime.NativeAOT.35.android-x64 Currently, the contents of all these packs are identical, but this is an initial step to build multiple packs. The plan is for the workload to only install the "Mono" packs, and the "NativeAOT" packs can be restored via NuGet.
jonathanpeppers
commented
Nov 21, 2024
MemberAuthor
I think the main question here is if we are ok with the new naming scheme:
|
pjcollins
approved these changes
Nov 22, 2024
pjcollins
left a comment
Member
There was a problem hiding this comment.
Approach and names seem good to me here, we can always rename if we come up with something better later
jonathanpeppers added a commit
that referenced
this pull request
Dec 6, 2024
Context: #9538 Context: #9583 Expanding upon #9538, there are more changes required to support multiple runtime flavors in our build. * Remove `$(MicrosoftAndroidArmPackDir)` and related properties, to rely on a new `@(AndroidAbiAndRuntimeFlavor)` item group instead. * Exclude our Mono-related native libraries from NativeAOT runtime packs. * Ensure that our runtime packs copy assemblies (`Mono.Android.dll`, etc.) to the appropriate NativeAOT-related directories. * List our `Microsoft.Android.Runtime.NativeAOT.*` packs in the `WorkloadManifest.json`, so that `**FromWorkload**` can resolve the version number for them. They can still restore via NuGet.
jonathanpeppers added a commit
that referenced
this pull request
Dec 6, 2024
Context: #9538 Context: #9583 Expanding upon #9538, there are more changes required to support multiple runtime flavors in our build. * Remove `$(MicrosoftAndroidArmPackDir)` and related properties, to rely on a new `@(AndroidAbiAndRuntimeFlavor)` item group instead. * Exclude our Mono-related native libraries from NativeAOT runtime packs. * Ensure that our runtime packs copy assemblies (`Mono.Android.dll`, etc.) to the appropriate NativeAOT-related directories. * List our `Microsoft.Android.Runtime.NativeAOT.*` packs in the `WorkloadManifest.json`, so that `**FromWorkload**` can resolve the version number for them. They can still restore via NuGet.
jonathanpeppers added a commit
that referenced
this pull request
Dec 9, 2024
Context: #9538 Context: #9583 Expanding upon #9538, there are more changes required to support multiple runtime flavors in our build. * Remove `$(MicrosoftAndroidArmPackDir)` and related properties, to rely on a new `@(AndroidAbiAndRuntimeFlavor)` item group instead. * Exclude our Mono-related native libraries from NativeAOT runtime packs. * Ensure that our runtime packs copy assemblies (`Mono.Android.dll`, etc.) to the appropriate NativeAOT-related directories. * List our `Microsoft.Android.Runtime.NativeAOT.*` packs in the `WorkloadManifest.json`, so that `**FromWorkload**` can resolve the version number for them. They can still restore via NuGet.
jonathanpeppers added a commit
that referenced
this pull request
Dec 9, 2024
Context: #9538 Context: #9583 Expanding upon #9538, there are more changes required to support multiple runtime flavors in our build. * Remove `$(MicrosoftAndroidArmPackDir)` and related properties, to rely on a new `@(AndroidAbiAndRuntimeFlavor)` item group instead. * Exclude our Mono-related native libraries from NativeAOT runtime packs. * Ensure that our runtime packs copy assemblies (`Mono.Android.dll`, etc.) to the appropriate NativeAOT-related directories. * List our `Microsoft.Android.Runtime.NativeAOT.*` packs in the `WorkloadManifest.json`, so that `**FromWorkload**` can resolve the version number for them. They can still restore via NuGet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now our runtime packs are all identical for each .NET "runtime", but we want to be able to produce different packs, such as:
Currently, the contents of all these packs are identical, but this is an initial step to build multiple packs.
The plan is for the workload to only install the "Mono" packs, and the "NativeAOT" packs can be restored via NuGet.