Uh oh!
There was an error while loading. Please reload this page.
[build] runtime "flavors" part 2 - #9598
Merged
Merged
Conversation
jonathanpeppersforce-pushed
the
dev/peppers/runtime/flavor/part2
branch
from
December 6, 2024 17:11
0f0de53 to
3729f16Comparejpobst
commented
Dec 6, 2024
Contributor
Just a nitpick, but should the runtime be "CoreCLR" instead of "NativeAOT"? |
jonathanpeppers
commented
Dec 6, 2024
MemberAuthor
Not adding CoreCLR yet, I have NativeAOT's build working (apps don't run) within our targets here: There are a few hacks, mostly related to forcing the We might be able to merge it next week and then think about getting "hello world" to actually run on NativeAOT. |
This comment was marked as outdated.
This comment was marked as outdated.
Context: #9538 Context: #9583 Expanding upon #9538, there are more changes required to support multiple runtime flavors in our build. * Remove `$(MicrosoftAndroidArmPackDir)` and related properties, to rely on a new `@(AndroidAbiAndRuntimeFlavor)` item group instead. * Exclude our Mono-related native libraries from NativeAOT runtime packs. * Ensure that our runtime packs copy assemblies (`Mono.Android.dll`, etc.) to the appropriate NativeAOT-related directories. * List our `Microsoft.Android.Runtime.NativeAOT.*` packs in the `WorkloadManifest.json`, so that `**FromWorkload**` can resolve the version number for them. They can still restore via NuGet.
jonathanpeppersforce-pushed
the
dev/peppers/runtime/flavor/part2
branch
from
December 9, 2024 14:40
3729f16 to
c04fddeCompare
This comment was marked as outdated.
This comment was marked as outdated.
jonathanpeppers
commented
Dec 9, 2024
MemberAuthor
The one test failure look ok to ignore: |
| "Microsoft.Android.Runtime.NativeAOT.35.android-x64": { | ||
| "kind": "framework", | ||
| "version": "@WORKLOAD_VERSION@" | ||
| }, |
Member
There was a problem hiding this comment.
As we continue to expand this list, we probably will want to revisit dotnet/sdk#24077 / dotnet/sdk#24873. For .NET 10, we're very much going to want to come up with a way to cut down on the (now 8, ~soon to be 12?) duplicate versions of Mono.Android.dll (~35 MB each) and friends that we will be shipping.
pjcollins
approved these changes
Dec 9, 2024
pjcollins
left a comment
Member
There was a problem hiding this comment.
Looks good, but we should add a new issue or comment to the relevant backlog for this work to revisit generation of a "rid-less" runtime pack.
jonathanpeppers
commented
Dec 9, 2024
MemberAuthor
I filed this for the future: |
grendello added a commit
that referenced
this pull request
Jan 7, 2025
* main: (25 commits) [CI] Break "Linux Tests" into 2 parallel jobs. (#9642) Fix `WorkloadDependencies.proj` build. (#9648) [CI] Set "WearOS Tests" parallelization to 2 agents. (#9639) [CI] Break "Package Tests" into 2 parallel jobs. (#9638) Bump to DevDiv/android-platform-support@3b4e16f1 (#9632) [NativeAOT] improve build logic, part 2 (#9631) Bump to dotnet/java-interop@2c06b3c2 (#9633) [NativeAOT] improve build logic, part 1 (#9614) [build] Generate `WorkloadDependencies.json` (#9613) [monodroid] remove `monodroid_get_log_categories()` (#9625) [monodroid] remove `_monodroid_get_identity_hash_code` (#9622) Bump to dotnet/java-interop@f800ea52 (#9607) [XABT] Break BuildApk into individual tasks for each content type. (#9612) [Mono.Android] Bind Android API-Baklava DP1 (#9594) [Xamarin.Android.Build.Tasks] Extract `BuildArchive` from `BuildApk` (#9556) [NativeAOT] MSBuild-related logic to get projects to build (#9583) [build] remove remnants of `OpenTK-1.0.dll` (#9610) [build] remove `Xamarin.Android.CSharp.targets` (#9609) [build] runtime "flavors" part 2 (#9598) Bump com.android.tools.build:manifest-merger to 31.7.3 (#9600) ...
grendello added a commit
that referenced
this pull request
Jan 7, 2025
* dev/grendel/use-libc++: (25 commits) [CI] Break "Linux Tests" into 2 parallel jobs. (#9642) Fix `WorkloadDependencies.proj` build. (#9648) [CI] Set "WearOS Tests" parallelization to 2 agents. (#9639) [CI] Break "Package Tests" into 2 parallel jobs. (#9638) Bump to DevDiv/android-platform-support@3b4e16f1 (#9632) [NativeAOT] improve build logic, part 2 (#9631) Bump to dotnet/java-interop@2c06b3c2 (#9633) [NativeAOT] improve build logic, part 1 (#9614) [build] Generate `WorkloadDependencies.json` (#9613) [monodroid] remove `monodroid_get_log_categories()` (#9625) [monodroid] remove `_monodroid_get_identity_hash_code` (#9622) Bump to dotnet/java-interop@f800ea52 (#9607) [XABT] Break BuildApk into individual tasks for each content type. (#9612) [Mono.Android] Bind Android API-Baklava DP1 (#9594) [Xamarin.Android.Build.Tasks] Extract `BuildArchive` from `BuildApk` (#9556) [NativeAOT] MSBuild-related logic to get projects to build (#9583) [build] remove remnants of `OpenTK-1.0.dll` (#9610) [build] remove `Xamarin.Android.CSharp.targets` (#9609) [build] runtime "flavors" part 2 (#9598) Bump com.android.tools.build:manifest-merger to 31.7.3 (#9600) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #9538
Context: #9583
Expanding upon #9538, there are more changes required to support multiple runtime flavors in our build.
Remove
$(MicrosoftAndroidArmPackDir)and related properties, to rely on a new@(AndroidAbiAndRuntimeFlavor)item group instead.Exclude our Mono-related native libraries from NativeAOT runtime packs.
Ensure that our runtime packs copy assemblies (
Mono.Android.dll, etc.) to the appropriate NativeAOT-related directories.List our
Microsoft.Android.Runtime.NativeAOT.*packs in theWorkloadManifest.json, so that**FromWorkload**can resolve the version number for them. They can still restore via NuGet.