Skip to content

Apply schema transformer to AdditionalProperties - #59699

Merged
captainsafia merged 1 commit into
dotnet:mainfrom
JTeeuwissen:additionalProperties
Jan 6, 2025
Merged

Apply schema transformer to AdditionalProperties#59699
captainsafia merged 1 commit into
dotnet:mainfrom
JTeeuwissen:additionalProperties

Conversation

@JTeeuwissen

@JTeeuwissenJTeeuwissen commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

Apply schema transformer to AdditionalProperties

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Applied InnerApplySchemaTransformersAsync to AdditionalProperties where AdditionalPropertiesAllowed and jsonTypeInfo has an ElementType

Description

Fixed schema generation for AdditionalProperties, the result of a dictionary value type.

Fixes#59616

@JTeeuwissen
JTeeuwissen requested review from a team and captainsafia as code ownersJanuary 3, 2025 07:06
@ghostghost added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Jan 3, 2025
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jan 3, 2025
@dotnet-policy-servicedotnet-policy-serviceBot added this to the 9.0.x milestone Jan 3, 2025
@captainsafia

captainsafia commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

@JTeeuwissen Thanks for opening this PR! It looks great overall and is good to merge.

However, it's currently set up to target the release/9.0 branch. Can you update it to retarget to main?

Since .NET 9 is publicly released, changes to it have to go through the servicing process in order to make it in. The servicing process is documented here.

TL;DR: We'll retarget this PR to main and merge. Then we'll open a backport PR to release/9.0 and I'll take it through the servicing process for incorporation into the patch releases.

@captainsafiacaptainsafia added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc pr: pending author input For automation. Specifically separate from Needs: Author Feedback and removed old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels labels Jan 3, 2025
@JTeeuwissen
JTeeuwissen changed the base branch from release/9.0 to mainJanuary 3, 2025 15:56
@JTeeuwissen
JTeeuwissen changed the base branch from main to release/9.0January 3, 2025 15:56
@JTeeuwissen
JTeeuwissen changed the base branch from release/9.0 to mainJanuary 3, 2025 16:02
@captainsafia
captainsafia removed request for a teamJanuary 3, 2025 16:06
@mkArtakMSFTmkArtakMSFT added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Jan 3, 2025
@JTeeuwissen

JTeeuwissen commented Jan 6, 2025

Copy link
Copy Markdown
ContributorAuthor

@dotnet-policy-service agree

@captainsafiacaptainsafia removed this from the 9.0.x milestone Jan 6, 2025
@captainsafiacaptainsafia removed the pr: pending author input For automation. Specifically separate from Needs: Author Feedback label Jan 6, 2025
captainsafia
captainsafia approved these changes Jan 6, 2025
View reviewed changes

@captainsafiacaptainsafia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for dealing with the branch change and CLA agreement!

@captainsafia
captainsafia merged commit a1f4e1b into dotnet:mainJan 6, 2025
@captainsafia

captainsafia commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

/backport to release/9.0

@dotnet-policy-servicedotnet-policy-serviceBot added this to the 10.0-preview1 milestone Jan 6, 2025
@github-actions

github-actionsBot commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/12634564157

@github-actionsgithub-actionsBot mentioned this pull request Jan 6, 2025
Merged
10 tasks
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
@JTeeuwissen@captainsafia
Apply schema transformer to AdditionalProperties (#59699)
0ec9c3a
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@captainsafiacaptainsafiacaptainsafia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@captainsafiacaptainsafia

Labels

area-minimalIncludes minimal APIs, endpoint filters, parameter binding, request delegate generator etccommunity-contributionIndicates that the PR has been added by a community memberfeature-openapi

Projects

None yet

Milestone

10.0-preview1

Development

Successfully merging this pull request may close these issues.

Values of additionalProperties not transformed

3 participants

@JTeeuwissen@captainsafia@mkArtakMSFT