Skip to content

[release/9.0] Apply schema transformer to AdditionalProperties - #59730

Merged
wtgodbe merged 1 commit into
release/9.0from
backport/pr-59699-to-release/9.0
Jan 10, 2025
Merged

[release/9.0] Apply schema transformer to AdditionalProperties#59730
wtgodbe merged 1 commit into
release/9.0from
backport/pr-59699-to-release/9.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

Backport of #59699 to release/9.0

/cc @captainsafia@JTeeuwissen

Description

This pull request invokes the schema transformer to the AdditionalProperties field within the JSON schema.

Fixes#59616

Customer Impact

This change is necessary to ensure the schema transformer correctly applies to AdditionalProperties, a sub-field within the JSON schema.

While there are workarounds for this issue, the workarounds require the user to implement an extensive amount of custom code in order to properly recurse into an AdditionalProperties subschemas for a given type.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Low risk because:

  • Change is localized to Microsoft.AspNetCore.OpenApi package
  • Change is additive and doesn't change existing behavior

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@github-actions
github-actionsBot requested review from a team and captainsafia as code ownersJanuary 6, 2025 14:45
@ghostghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 6, 2025
@dotnet-policy-servicedotnet-policy-serviceBot added this to the 9.0.x milestone Jan 6, 2025
@captainsafiacaptainsafia added Servicing-consider Shiproom approval is required for the issue feature-openapi area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc labels Jan 6, 2025
@captainsafia

Copy link
Copy Markdown
Contributor

Approved via email.

@captainsafiacaptainsafia added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jan 10, 2025
@wtgodbe
wtgodbe merged commit 6238e5d into release/9.0Jan 10, 2025
@wtgodbe
wtgodbe deleted the backport/pr-59699-to-release/9.0 branch January 10, 2025 21:24
@dotnet-policy-servicedotnet-policy-serviceBot modified the milestones: 9.0.x, 9.0.2Jan 10, 2025
This was referenced Aug 13, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-minimalIncludes minimal APIs, endpoint filters, parameter binding, request delegate generator etcarea-mvcIncludes: MVC, Actions and Controllers, Localization, CORS, most templatesfeature-openapiServicing-approvedShiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@captainsafia@wtgodbe